]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies
authorStephan Gerhold <stephan.gerhold@linaro.org>
Tue, 3 Dec 2024 17:44:03 +0000 (18:44 +0100)
committerBjorn Andersson <andersson@kernel.org>
Fri, 14 Mar 2025 16:58:23 +0000 (11:58 -0500)
The WCD938x codec provides two controls for each of the MIC_BIASn outputs:

 - "MIC BIASn" enables an internal regulator to generate the output
   with a configurable voltage (qcom,micbiasN-microvolt).

 - "VA MIC BIASn" enables "pull-up mode" that bypasses the internal
   regulator and directly outputs fixed 1.8V from the VDD_PX pin.
   This is intended for low-power VA (voice activation) use cases.

The audio-routing setup for the X1E80100 CRD currently specifies both
as power supplies for the DMICs, but only one of them can be active
at the same time. In practice, only the internal regulator is used
with the current setup because the driver prefers it over pull-up mode.

Make this more clear by dropping the redundant routes to the pull-up
"VA MIC BIASn" supply. There is no functional difference except that we
skip briefly switching to pull-up mode when shutting down the microphone.

Fixes: 4442a67eedc1 ("arm64: dts: qcom: x1e80100-crd: add sound card")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Link: https://lore.kernel.org/r/20241203-x1e80100-va-mic-bias-v1-2-0dfd4d9b492c@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1-crd.dtsi

index 9e587dc5753282343a2675fd9415c6e4dbe71c27..5ea7b30983d9dbf90a381796a1a18edd69f32b8b 100644 (file)
                                "VA DMIC1", "MIC BIAS3",
                                "VA DMIC2", "MIC BIAS1",
                                "VA DMIC3", "MIC BIAS1",
-                               "VA DMIC0", "VA MIC BIAS3",
-                               "VA DMIC1", "VA MIC BIAS3",
-                               "VA DMIC2", "VA MIC BIAS1",
-                               "VA DMIC3", "VA MIC BIAS1",
                                "TX SWR_INPUT1", "ADC2_OUTPUT";
 
                wcd-playback-dai-link {