]> www.infradead.org Git - users/hch/block.git/commitdiff
pinctrl: imx: off by one in imx_pinconf_group_dbg_show()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 19 Jul 2018 08:16:48 +0000 (11:16 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Sun, 29 Jul 2018 21:23:05 +0000 (23:23 +0200)
The > should really be >= here.  It's harmless because
pinctrl_generic_get_group() will return a NULL if group is invalid.

Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver")
Reported-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx.c

index 1c6bb15579e1e5d82a715cb9edea2aeea21384be..b04edc22dad7652ca2d9661b3cac31ed52224de8 100644 (file)
@@ -383,7 +383,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
        const char *name;
        int i, ret;
 
-       if (group > pctldev->num_groups)
+       if (group >= pctldev->num_groups)
                return;
 
        seq_puts(s, "\n");