Remove duplicate strdup() calls

The arguments of openconnect_set_mobile_info() have been strdup'ed:
- prior to passing them to openconnect_set_mobile_info(),
- inside openconnect_set_mobile_info().

We don't need both. I have chosen to keep the strdup() call inside
openconnect_set_mobile_info(), and discard the strdup() of the arguments
just before calling openconnect_set_mobile_info().

Signed-off-by: Dimitri Papadopoulos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/main.c b/main.c
index 33b0df7567b8e5aad5e4bc94eadef7d142f56d1b..51b89f42c5758c9612cb758a1ecababea0717d2b 100644 (file)
--- a/main.c
+++ b/main.c
@@ -2247,9 +2247,9 @@ int main(int argc, char *argv[])
                        if (!strcmp(config_arg, "android") || !strcmp(config_arg, "apple-ios")) {
                                /* generic defaults */
                                openconnect_set_mobile_info(vpninfo,
-                                       xstrdup("1.0"),
-                                       dup_config_arg(),
-                                       xstrdup("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"));
+                                       "1.0",
+                                       config_arg,
+                                       "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA");
                        }
                        break;
                case OPT_PASSTOS: