]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
vfio/pci: Remove #ifdef iowrite64 and #ifdef ioread64
authorRamesh Thomas <ramesh.thomas@intel.com>
Tue, 10 Dec 2024 13:19:38 +0000 (05:19 -0800)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 6 Jan 2025 15:09:54 +0000 (08:09 -0700)
Remove the #ifdef iowrite64 and #ifdef ioread64 checks around calls to
64 bit IO access. Since default implementations have been enabled, the
checks are not required.

Signed-off-by: Ramesh Thomas <ramesh.thomas@intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20241210131938.303500-3-ramesh.thomas@intel.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/vfio_pci_rdwr.c

index a0595c745732a351243440e7f7841046909059e6..78a3d0809415e04c4681d6288c6e38b494fd63b0 100644 (file)
@@ -62,9 +62,7 @@ EXPORT_SYMBOL_GPL(vfio_pci_core_iowrite##size);
 VFIO_IOWRITE(8)
 VFIO_IOWRITE(16)
 VFIO_IOWRITE(32)
-#ifdef iowrite64
 VFIO_IOWRITE(64)
-#endif
 
 #define VFIO_IOREAD(size) \
 int vfio_pci_core_ioread##size(struct vfio_pci_core_device *vdev,      \
@@ -90,9 +88,7 @@ EXPORT_SYMBOL_GPL(vfio_pci_core_ioread##size);
 VFIO_IOREAD(8)
 VFIO_IOREAD(16)
 VFIO_IOREAD(32)
-#ifdef ioread64
 VFIO_IOREAD(64)
-#endif
 
 #define VFIO_IORDWR(size)                                              \
 static int vfio_pci_iordwr##size(struct vfio_pci_core_device *vdev,\
@@ -128,9 +124,7 @@ static int vfio_pci_iordwr##size(struct vfio_pci_core_device *vdev,\
 VFIO_IORDWR(8)
 VFIO_IORDWR(16)
 VFIO_IORDWR(32)
-#if defined(ioread64) && defined(iowrite64)
 VFIO_IORDWR(64)
-#endif
 
 /*
  * Read or write from an __iomem region (MMIO or I/O port) with an excluded
@@ -156,7 +150,6 @@ ssize_t vfio_pci_core_do_io_rw(struct vfio_pci_core_device *vdev, bool test_mem,
                else
                        fillable = 0;
 
-#if defined(ioread64) && defined(iowrite64)
                if (fillable >= 8 && !(off % 8)) {
                        ret = vfio_pci_iordwr64(vdev, iswrite, test_mem,
                                                io, buf, off, &filled);
@@ -164,7 +157,6 @@ ssize_t vfio_pci_core_do_io_rw(struct vfio_pci_core_device *vdev, bool test_mem,
                                return ret;
 
                } else
-#endif
                if (fillable >= 4 && !(off % 4)) {
                        ret = vfio_pci_iordwr32(vdev, iswrite, test_mem,
                                                io, buf, off, &filled);
@@ -382,12 +374,10 @@ static void vfio_pci_ioeventfd_do_write(struct vfio_pci_ioeventfd *ioeventfd,
                vfio_pci_core_iowrite32(ioeventfd->vdev, test_mem,
                                        ioeventfd->data, ioeventfd->addr);
                break;
-#ifdef iowrite64
        case 8:
                vfio_pci_core_iowrite64(ioeventfd->vdev, test_mem,
                                        ioeventfd->data, ioeventfd->addr);
                break;
-#endif
        }
 }
 
@@ -441,10 +431,8 @@ int vfio_pci_ioeventfd(struct vfio_pci_core_device *vdev, loff_t offset,
              pos >= vdev->msix_offset + vdev->msix_size))
                return -EINVAL;
 
-#ifndef iowrite64
        if (count == 8)
                return -EINVAL;
-#endif
 
        ret = vfio_pci_core_setup_barmap(vdev, bar);
        if (ret)