]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
gdbstub: fix address type of gdb_set_cpu_pc
authorAlex Bennée <alex.bennee@linaro.org>
Fri, 3 Mar 2023 02:57:54 +0000 (18:57 -0800)
committerAlex Bennée <alex.bennee@linaro.org>
Tue, 7 Mar 2023 20:44:08 +0000 (20:44 +0000)
The underlying call uses vaddr and the comms API uses unsigned long
long which will always fit. We don't need to deal in target_ulong
here.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230302190846.2593720-19-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-19-richard.henderson@linaro.org>

gdbstub/gdbstub.c

index 7301466ff5519343b19bdd6a040be408fdeafe1e..b8aead03bdddc993cb6cf30abfd85a40fc6bc279 100644 (file)
@@ -535,7 +535,7 @@ static void gdb_process_breakpoint_remove_all(GDBProcess *p)
 }
 
 
-static void gdb_set_cpu_pc(target_ulong pc)
+static void gdb_set_cpu_pc(vaddr pc)
 {
     CPUState *cpu = gdbserver_state.c_cpu;
 
@@ -1290,7 +1290,7 @@ static void handle_file_io(GArray *params, void *user_ctx)
 static void handle_step(GArray *params, void *user_ctx)
 {
     if (params->len) {
-        gdb_set_cpu_pc((target_ulong)get_param(params, 0)->val_ull);
+        gdb_set_cpu_pc(get_param(params, 0)->val_ull);
     }
 
     cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags);