]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
mm: migrate: remove PageHead() check for HugeTLB in add_page_for_migration()
authorKefeng Wang <wangkefeng.wang@huawei.com>
Wed, 13 Sep 2023 09:51:30 +0000 (17:51 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 4 Oct 2023 17:32:28 +0000 (10:32 -0700)
There is some different between hugeTLB and THP behave when passed the
address of a tail page, for THP, it will migrate the entire THP page, but
for HugeTLB, it will return -EACCES, or -ENOENT before commit e66f17ff7177
("mm/hugetlb: take page table lock in follow_huge_pmd()"),

  -EACCES The page is mapped by multiple processes and can be moved
  only if MPOL_MF_MOVE_ALL is specified.
  -ENOENT The page is not present.

But when check manual[1], both of the two errnos are not suitable, it is
better to keep the same behave between hugetlb and THP when passed the
address of a tail page, so let's just remove the PageHead() check for
HugeTLB.

[1] https://man7.org/linux/man-pages/man2/move_pages.2.html

Link: https://lkml.kernel.org/r/20230913095131.2426871-8-wangkefeng.wang@huawei.com
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Zi Yan <ziy@nvidia.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: "Huang, Ying" <ying.huang@intel.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/migrate.c

index ce01d03e635a880f65638352df5b387ff772681d..8495e7e02dd48f2d19164943ab6329651270333b 100644 (file)
@@ -2096,10 +2096,8 @@ static int add_page_for_migration(struct mm_struct *mm, const void __user *p,
                goto out_putfolio;
 
        if (folio_test_hugetlb(folio)) {
-               if (PageHead(page)) {
-                       isolated = isolate_hugetlb(folio, pagelist);
-                       err = isolated ? 1 : -EBUSY;
-               }
+               isolated = isolate_hugetlb(folio, pagelist);
+               err = isolated ? 1 : -EBUSY;
        } else {
                isolated = folio_isolate_lru(folio);
                if (!isolated) {