]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
Revert "KVM: Avoid useless memory write when possible" kvm-33
authorAvi Kivity <avi@qumranet.com>
Mon, 23 Jul 2007 15:33:14 +0000 (18:33 +0300)
committerAvi Kivity <avi@qumranet.com>
Mon, 23 Jul 2007 15:33:14 +0000 (18:33 +0300)
This reverts commit 8a1449563b3e5ede56b28cc977c8da22a17cdf51.  While it
does save useless updates, it (probably) defeats the fork detector, causing
a massive performance loss.

Signed-off-by: Avi Kivity <avi@qumranet.com>
drivers/kvm/kvm_main.c

index 7c9bd72f74d5cc67aaaf751e183245e79386b9e7..6e11871f531923e72e60e521fad9c5bfd8585790 100644 (file)
@@ -1085,10 +1085,8 @@ static int emulator_write_phys(struct kvm_vcpu *vcpu, gpa_t gpa,
                return 0;
        mark_page_dirty(vcpu->kvm, gpa >> PAGE_SHIFT);
        virt = kmap_atomic(page, KM_USER0);
-       if (memcmp(virt + offset_in_page(gpa), val, bytes)) {
-               kvm_mmu_pte_write(vcpu, gpa, virt + offset, val, bytes);
-               memcpy(virt + offset_in_page(gpa), val, bytes);
-       }
+       kvm_mmu_pte_write(vcpu, gpa, virt + offset, val, bytes);
+       memcpy(virt + offset_in_page(gpa), val, bytes);
        kunmap_atomic(virt, KM_USER0);
        return 1;
 }