]> www.infradead.org Git - linux.git/commitdiff
block: Fix elevator_get_default() checking for NULL q->tag_set
authorSurajSonawane2415 <surajsonawane0215@gmail.com>
Mon, 7 Oct 2024 11:14:16 +0000 (16:44 +0530)
committerJens Axboe <axboe@kernel.dk>
Mon, 7 Oct 2024 20:24:36 +0000 (14:24 -0600)
elevator_get_default() and elv_support_iosched() both check for whether
or not q->tag_set is non-NULL, however it's not possible for them to be
NULL. This messes up some static checkers, as the checking of tag_set
isn't consistent.

Remove the checks, which both simplifies the logic and avoids checker
errors.

Signed-off-by: SurajSonawane2415 <surajsonawane0215@gmail.com>
Link: https://lore.kernel.org/r/20241007111416.13814-1-surajsonawane0215@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/elevator.c

index 4122026b11f1a1399e76a880e699e3ef009732e8..60497e3b25b0da6e0dab5d873ee028cbe2ca0fe1 100644 (file)
@@ -551,7 +551,7 @@ EXPORT_SYMBOL_GPL(elv_unregister);
 static inline bool elv_support_iosched(struct request_queue *q)
 {
        if (!queue_is_mq(q) ||
-           (q->tag_set && (q->tag_set->flags & BLK_MQ_F_NO_SCHED)))
+           (q->tag_set->flags & BLK_MQ_F_NO_SCHED))
                return false;
        return true;
 }
@@ -562,7 +562,7 @@ static inline bool elv_support_iosched(struct request_queue *q)
  */
 static struct elevator_type *elevator_get_default(struct request_queue *q)
 {
-       if (q->tag_set && q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)
+       if (q->tag_set->flags & BLK_MQ_F_NO_SCHED_BY_DEFAULT)
                return NULL;
 
        if (q->nr_hw_queues != 1 &&