]> www.infradead.org Git - users/hch/misc.git/commitdiff
udp: expand SKB_DROP_REASON_UDP_CSUM use
authorEric Dumazet <edumazet@google.com>
Fri, 7 Mar 2025 10:20:02 +0000 (10:20 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 16:56:04 +0000 (08:56 -0800)
SKB_DROP_REASON_UDP_CSUM can be used in four locations
when dropping a packet because of a wrong UDP checksum.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250307102002.2095238-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/udp.c
net/ipv6/udp.c

index 17c7736d8349433ad2d4cbcc9414b2f8112610af..d0bffcfa56d8deb14f38cc48a4a2b1d899ad6af4 100644 (file)
@@ -1848,7 +1848,7 @@ static struct sk_buff *__first_packet_length(struct sock *sk,
                        atomic_inc(&sk->sk_drops);
                        __skb_unlink(skb, rcvq);
                        *total += skb->truesize;
-                       kfree_skb(skb);
+                       kfree_skb_reason(skb, SKB_DROP_REASON_UDP_CSUM);
                } else {
                        udp_skb_csum_unnecessary_set(skb);
                        break;
@@ -2002,7 +2002,7 @@ try_again:
                __UDP_INC_STATS(net, UDP_MIB_CSUMERRORS, is_udplite);
                __UDP_INC_STATS(net, UDP_MIB_INERRORS, is_udplite);
                atomic_inc(&sk->sk_drops);
-               kfree_skb(skb);
+               kfree_skb_reason(skb, SKB_DROP_REASON_UDP_CSUM);
                goto try_again;
        }
 
@@ -2117,7 +2117,7 @@ csum_copy_err:
                UDP_INC_STATS(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite);
                UDP_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
        }
-       kfree_skb(skb);
+       kfree_skb_reason(skb, SKB_DROP_REASON_UDP_CSUM);
 
        /* starting over for a new packet, but check if we need to yield */
        cond_resched();
index 3a0d6c5a8286b1685e8a1dec50365fe392ab9a87..024458ef163c9e24dfb37aea2690b2030f6a0fbc 100644 (file)
@@ -586,7 +586,7 @@ csum_copy_err:
                SNMP_INC_STATS(mib, UDP_MIB_CSUMERRORS);
                SNMP_INC_STATS(mib, UDP_MIB_INERRORS);
        }
-       kfree_skb(skb);
+       kfree_skb_reason(skb, SKB_DROP_REASON_UDP_CSUM);
 
        /* starting over for a new packet, but check if we need to yield */
        cond_resched();