PCI: histb: Fix an error handling path in histb_pcie_probe()

If an error occurs after a successful phy_init() call, then phy_exit()
should be called.

Add the missing call, as already done in the remove function.

Fixes: bbd11bddb398 ("PCI: hisi: Add HiSilicon STB SoC PCIe controller driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[kwilczynski: remove unnecessary hipcie->phy NULL check from
histb_pcie_probe() and squash a patch that removes similar NULL
check for hipcie-phy from histb_pcie_remove() from
https://lore.kernel.org/linux-pci/c369b5d25e17a44984ae5a889ccc28a59a0737f7.1742058005.git.christophe.jaillet@wanadoo.fr]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Link: https://lore.kernel.org/r/8301fc15cdea5d2dac21f57613e8e6922fb1ad95.1740854531.git.christophe.jaillet@wanadoo.fr

diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
index 615a0e3e6d7eb5ee35123acbf7fc5f3defcc0cee..1f2f4c28a94957c9164f4893993bef0a3a5e9b71 100644 (file)
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -409,16 +409,21 @@ static int histb_pcie_probe(struct platform_device *pdev)
        ret = histb_pcie_host_enable(pp);
        if (ret) {
                dev_err(dev, "failed to enable host\n");
-               return ret;
+               goto err_exit_phy;
        }
 
        ret = dw_pcie_host_init(pp);
        if (ret) {
                dev_err(dev, "failed to initialize host\n");
-               return ret;
+               goto err_exit_phy;
        }
 
        return 0;
+
+err_exit_phy:
+       phy_exit(hipcie->phy);
+
+       return ret;
 }
 
 static void histb_pcie_remove(struct platform_device *pdev)
@@ -427,8 +432,7 @@ static void histb_pcie_remove(struct platform_device *pdev)
 
        histb_pcie_host_disable(hipcie);
 
-       if (hipcie->phy)
-               phy_exit(hipcie->phy);
+       phy_exit(hipcie->phy);
 }
 
 static const struct of_device_id histb_pcie_of_match[] = {