drm/i915: move comments about FSB straps to proper place

Move the comment about FSB straps to where the relevant register is
read.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/8a5b6cd3db80259c30263861f1a9ff04fea2e7f0.1718356614.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index b6adcbd9025fcd7f57f7a04328b5a8838603b6a4..16d5550f7e5e565d464ebf28dc253817acaac3a3 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -3542,16 +3542,7 @@ static int vlv_hrawclk(struct drm_i915_private *dev_priv)
 
 static int i9xx_hrawclk(struct drm_i915_private *i915)
 {
-       /*
-        * hrawclock is 1/4 the FSB frequency
-        *
-        * Note that this only reads the state of the FSB
-        * straps, not the actual FSB frequency. Some BIOSen
-        * let you configure each independently. Ideally we'd
-        * read out the actual FSB frequency but sadly we
-        * don't know which registers have that information,
-        * and all the relevant docs have gone to bit heaven :(
-        */
+       /* hrawclock is 1/4 the FSB frequency */
        return DIV_ROUND_CLOSEST(i9xx_fsb_freq(i915), 4);
 }
 

diff --git a/drivers/gpu/drm/i915/soc/intel_dram.c b/drivers/gpu/drm/i915/soc/intel_dram.c
index dac39b41fa517ae9cfd0fd84324efe730ddb7d86..4aba47bccc6366583d1d701731cd69f70b3458e9 100644 (file)
--- a/drivers/gpu/drm/i915/soc/intel_dram.c
+++ b/drivers/gpu/drm/i915/soc/intel_dram.c
@@ -146,6 +146,14 @@ unsigned int i9xx_fsb_freq(struct drm_i915_private *i915)
 {
        u32 fsb;
 
+       /*
+        * Note that this only reads the state of the FSB
+        * straps, not the actual FSB frequency. Some BIOSen
+        * let you configure each independently. Ideally we'd
+        * read out the actual FSB frequency but sadly we
+        * don't know which registers have that information,
+        * and all the relevant docs have gone to bit heaven :(
+        */
        fsb = intel_uncore_read(&i915->uncore, CLKCFG) & CLKCFG_FSB_MASK;
 
        if (IS_PINEVIEW(i915) || IS_MOBILE(i915)) {