]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: dsa: b53: Drop BCM5301x workaround for a wrong CPU/IMP port
authorRafał Miłecki <rafal@milecki.pl>
Thu, 16 Sep 2021 12:03:52 +0000 (14:03 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Sep 2021 02:06:35 +0000 (19:06 -0700)
On BCM5301x port 8 requires a fixed link when used.

Years ago when b53 was an OpenWrt downstream driver (with configuration
based on sometimes bugged NVRAM) there was a need for a fixup. In case
of forcing fixed link for (incorrectly specified) port 5 the code had to
actually setup port 8 link.

For upstream b53 driver with setup based on DT there is no need for that
workaround. In DT we have and require correct ports setup.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c

index 47a00c5364c7e2bfeaf251c43ac6febf740bf747..ca84e32baca0d6d174a8ed82eba2ffbc199f2bc2 100644 (file)
@@ -1291,12 +1291,6 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,
                                return;
                        }
                }
-       } else if (is5301x(dev)) {
-               if (port != dev->cpu_port) {
-                       b53_force_port_config(dev, dev->cpu_port, 2000,
-                                             DUPLEX_FULL, true, true);
-                       b53_force_link(dev, dev->cpu_port, 1);
-               }
        }
 
        /* Re-negotiate EEE if it was enabled already */