mtd: rawnand: rockchip: ensure NVDDR timings are rejected

.setup_interface first gets called with a "target" value of
NAND_DATA_IFACE_CHECK_ONLY, in which case an error is expected
if the controller driver does not support the timing mode (NVDDR).

Fixes: a9ecc8c814e9 ("mtd: rawnand: Choose the best timings, NV-DDR included")
Signed-off-by: Val Packett <val@packett.cool>
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20240519031409.26464-1-val@packett.cool

diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
index 7baaef69d70ad426c4989981a13d8c1b5d0cdf9b..55580447633be0704e4ab88aacdb5b4f34e90f25 100644 (file)
--- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
+++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
@@ -420,13 +420,13 @@ static int rk_nfc_setup_interface(struct nand_chip *chip, int target,
        u32 rate, tc2rw, trwpw, trw2c;
        u32 temp;
 
-       if (target < 0)
-               return 0;
-
        timings = nand_get_sdr_timings(conf);
        if (IS_ERR(timings))
                return -EOPNOTSUPP;
 
+       if (target < 0)
+               return 0;
+
        if (IS_ERR(nfc->nfc_clk))
                rate = clk_get_rate(nfc->ahb_clk);
        else