]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/bridge: cdns-mhdp8546: Remove a redundant check on existence of bridge->encoder
authorSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 13 May 2024 15:31:04 +0000 (23:31 +0800)
committerRobert Foss <rfoss@kernel.org>
Mon, 13 May 2024 16:31:06 +0000 (18:31 +0200)
In the cdns_mhdp_connector_init() function, the check on the existence
of bridge->encoder is not necessary, as it has already been checked in
the drm_bridge_attach() function. As the cdns_mhdp_connector_init() is
only called by cdns_mhdp_attach(), it is guaranteed that the .encoder
member of the struct drm_bridge is not NULL when cdns_mhdp_attach() gets
called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-8-sui.jingfeng@linux.dev
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c

index 8a91ef0ae0651291002b170efeb82d8c101fbd3e..dee640ab1d3ad5b3550fcee9caa385c3bbc75dd5 100644 (file)
@@ -1697,11 +1697,6 @@ static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp)
        struct drm_bridge *bridge = &mhdp->bridge;
        int ret;
 
-       if (!bridge->encoder) {
-               dev_err(mhdp->dev, "Parent encoder object not found");
-               return -ENODEV;
-       }
-
        conn->polled = DRM_CONNECTOR_POLL_HPD;
 
        ret = drm_connector_init(bridge->dev, conn, &cdns_mhdp_conn_funcs,