]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amdgpu: fix i2s_pdata out of bound array access
authorVijendar Mukunda <Vijendar.Mukunda@amd.com>
Wed, 27 Jul 2022 10:45:43 +0000 (16:15 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Jul 2022 20:05:16 +0000 (16:05 -0400)
Fixed following Smatch static checker warning:

    drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init()
    error: buffer overflow 'i2s_pdata' 3 <= 3
    drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init()
    error: buffer overflow 'i2s_pdata' 3 <= 3

Fixes: 4c33e5179ff1 ("drm/amdgpu: create I2S platform devices for Jadeite platform")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c

index bcc7ee02e0fcb7a5ba892bd0d3117a68697c84e4..6d72355ac4928f3def436ff02d5ea2c9b7f9580c 100644 (file)
@@ -390,14 +390,6 @@ static int acp_hw_init(void *handle)
                i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET;
                i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET;
 
-               i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET;
-               switch (adev->asic_type) {
-               case CHIP_STONEY:
-                       i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;
-                       break;
-               default:
-                       break;
-               }
                adev->acp.acp_res[0].name = "acp2x_dma";
                adev->acp.acp_res[0].flags = IORESOURCE_MEM;
                adev->acp.acp_res[0].start = acp_base;