]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
crypto: nitrox - fix unchecked variable in nitrox_register_interrupts
authorTong Tiangen <tongtiangen@huawei.com>
Tue, 1 Jun 2021 10:01:55 +0000 (18:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:22 +0000 (16:53 +0200)
[ Upstream commit 57c126661f50b884d3812e7db6e00f2e778eccfb ]

Function nitrox_register_interrupts leaves variable 'nr_vecs' unchecked, which
would be use as kcalloc parameter later.

Fixes: 5155e118dda9 ("crypto: cavium/nitrox - use pci_alloc_irq_vectors() while enabling MSI-X.")
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/cavium/nitrox/nitrox_isr.c

index 3dec570a190ad5efca0696831a281307f1f185a3..10e3408bf704cede60ca0de7745e86b4c9d248c7 100644 (file)
@@ -306,6 +306,10 @@ int nitrox_register_interrupts(struct nitrox_device *ndev)
         * Entry 192: NPS_CORE_INT_ACTIVE
         */
        nr_vecs = pci_msix_vec_count(pdev);
+       if (nr_vecs < 0) {
+               dev_err(DEV(ndev), "Error in getting vec count %d\n", nr_vecs);
+               return nr_vecs;
+       }
 
        /* Enable MSI-X */
        ret = pci_alloc_irq_vectors(pdev, nr_vecs, nr_vecs, PCI_IRQ_MSIX);