]> www.infradead.org Git - nvme.git/commitdiff
nvmet: auth: use NULL to clear a pointer in nvmet_auth_sq_free()
authorDamien Le Moal <dlemoal@kernel.org>
Fri, 11 Apr 2025 01:00:15 +0000 (10:00 +0900)
committerChristoph Hellwig <hch@lst.de>
Wed, 16 Apr 2025 05:37:36 +0000 (07:37 +0200)
When compiling with C=1, the following sparse warning is generated:

auth.c:243:23: warning: Using plain integer as NULL pointer

Avoid this warning by using NULL to instead of 0 to set the sq tls_key
pointer.

Fixes: fa2e0f8bbc68 ("nvmet-tcp: support secure channel concatenation")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/auth.c

index 0b0645ac5df4782927b131c0bf040dee176b294b..cef8d77f477b9584f1234442ceeede97af181aaa 100644 (file)
@@ -240,7 +240,7 @@ void nvmet_auth_sq_free(struct nvmet_sq *sq)
 {
        cancel_delayed_work(&sq->auth_expired_work);
 #ifdef CONFIG_NVME_TARGET_TCP_TLS
-       sq->tls_key = 0;
+       sq->tls_key = NULL;
 #endif
        kfree(sq->dhchap_c1);
        sq->dhchap_c1 = NULL;