tty: rfcomm: prefer array indexing over pointer arithmetic

Refactor the list_for_each_entry() loop of rfcomm_get_dev_list()
function to use array indexing instead of pointer arithmetic.

This way, the code is more readable and idiomatic.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

diff --git a/net/bluetooth/rfcomm/tty.c b/net/bluetooth/rfcomm/tty.c
index 44b781e7569e3fb020c14f87bd89565042e5f968..af80d599c33715a17787b9c3fc0b4d45f5f68a11 100644 (file)
--- a/net/bluetooth/rfcomm/tty.c
+++ b/net/bluetooth/rfcomm/tty.c
@@ -527,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg)
        list_for_each_entry(dev, &rfcomm_dev_list, list) {
                if (!tty_port_get(&dev->port))
                        continue;
-               (di + n)->id      = dev->id;
-               (di + n)->flags   = dev->flags;
-               (di + n)->state   = dev->dlc->state;
-               (di + n)->channel = dev->channel;
-               bacpy(&(di + n)->src, &dev->src);
-               bacpy(&(di + n)->dst, &dev->dst);
+               di[n].id      = dev->id;
+               di[n].flags   = dev->flags;
+               di[n].state   = dev->dlc->state;
+               di[n].channel = dev->channel;
+               bacpy(&di[n].src, &dev->src);
+               bacpy(&di[n].dst, &dev->dst);
                tty_port_put(&dev->port);
                if (++n >= dev_num)
                        break;