]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
tg3: remove redundant NULL test before release_firmware() call
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:50:15 +0000 (22:50 +0200)
committerJoe Jin <joe.jin@oracle.com>
Tue, 28 Aug 2012 07:23:07 +0000 (15:23 +0800)
There is no need to test for a NULL pointer before calling
release_firmware - the function does that on its own.

(cherry picked from commit e3c5530b96b9c5994cfb2544a037161790c4f7c3)
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/tg3.c

index cb0db80b1c9f7518572fda1f8f59a3400747d414..786eb244cf6b924e3ff030ad6b576dbeb11b7dee 100644 (file)
@@ -15852,8 +15852,7 @@ static void __devexit tg3_remove_one(struct pci_dev *pdev)
        if (dev) {
                struct tg3 *tp = netdev_priv(dev);
 
-               if (tp->fw)
-                       release_firmware(tp->fw);
+               release_firmware(tp->fw);
 
                tg3_reset_task_cancel(tp);