]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
pinctrl: mediatek: Use of_property_read_bool()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 19:13:01 +0000 (13:13 -0600)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Aug 2024 15:38:00 +0000 (17:38 +0200)
Use of_property_read_bool() to read boolean properties rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT struct property and data pointers which is a problem for
dynamically allocated nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/20240731191312.1710417-23-robh@kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/mediatek/pinctrl-paris.c

index e12316c4269805b931310fce157e899663a39976..87e958d827bf939aa6006794287698be4936f25e 100644 (file)
@@ -1044,11 +1044,8 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev)
 
        hw->nbase = hw->soc->nbase_names;
 
-       if (of_find_property(hw->dev->of_node,
-                            "mediatek,rsel-resistance-in-si-unit", NULL))
-               hw->rsel_si_unit = true;
-       else
-               hw->rsel_si_unit = false;
+       hw->rsel_si_unit = of_property_read_bool(hw->dev->of_node,
+                                                "mediatek,rsel-resistance-in-si-unit");
 
        spin_lock_init(&hw->lock);