drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check()

Writeback was the last user of dpu_encoder_phys_ops's atomic_check()
callback. As the code was moved to the dpu_writeback.c, the callback
becomes unused. Drop it now.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/577528/
Link: https://lore.kernel.org/r/20240208-fd_remove_phys_ops_atomic_mode_set-v4-5-caf5dcd125c0@linaro.org

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 679131f5c035f1d4235b20c73920cac12a302fe4..194dbb08331d23b8f8a511d0e6376e3a8ffe7708 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -591,7 +591,6 @@ static int dpu_encoder_virt_atomic_check(
        struct dpu_global_state *global_state;
        struct drm_framebuffer *fb;
        struct drm_dsc_config *dsc;
-       int i = 0;
        int ret = 0;
 
        if (!drm_enc || !crtc_state || !conn_state) {
@@ -612,20 +611,6 @@ static int dpu_encoder_virt_atomic_check(
 
        trace_dpu_enc_atomic_check(DRMID(drm_enc));
 
-       /* perform atomic check on the first physical encoder (master) */
-       for (i = 0; i < dpu_enc->num_phys_encs; i++) {
-               struct dpu_encoder_phys *phys = dpu_enc->phys_encs[i];
-
-               if (phys->ops.atomic_check)
-                       ret = phys->ops.atomic_check(phys, crtc_state,
-                                       conn_state);
-               if (ret) {
-                       DPU_ERROR_ENC(dpu_enc,
-                                       "mode unsupported, phys idx %d\n", i);
-                       return ret;
-               }
-       }
-
        dsc = dpu_encoder_get_dsc_config(drm_enc);
 
        topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode, crtc_state, dsc);

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
index 7eb8bdfe6bbedbfef94f28a8958f127fa63a8f13..dd9e3603d120bc476f7303028db7a85e8824b3c9 100644 (file)
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
@@ -71,7 +71,6 @@ struct dpu_encoder_phys;
  *                             on split_role and current mode (CMD/VID).
  * @enable:                    DRM Call. Enable a DRM mode.
  * @disable:                   DRM Call. Disable mode.
- * @atomic_check:              DRM Call. Atomic check new DRM state.
  * @control_vblank_irq         Register/Deregister for VBLANK IRQ
  * @wait_for_commit_done:      Wait for hardware to have flushed the
  *                             current pending frames to hardware
@@ -96,9 +95,6 @@ struct dpu_encoder_phys_ops {
        bool (*is_master)(struct dpu_encoder_phys *encoder);
        void (*enable)(struct dpu_encoder_phys *encoder);
        void (*disable)(struct dpu_encoder_phys *encoder);
-       int (*atomic_check)(struct dpu_encoder_phys *encoder,
-                           struct drm_crtc_state *crtc_state,
-                           struct drm_connector_state *conn_state);
        int (*control_vblank_irq)(struct dpu_encoder_phys *enc, bool enable);
        int (*wait_for_commit_done)(struct dpu_encoder_phys *phys_enc);
        int (*wait_for_tx_complete)(struct dpu_encoder_phys *phys_enc);