]> www.infradead.org Git - mtd-utils.git/commitdiff
mtd-utils: tests: Fix nandbiterrs Failure Check
authorHarpreet Eli Sangha <harpreet@nestlabs.com>
Tue, 27 Jun 2017 20:52:26 +0000 (13:52 -0700)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Wed, 28 Jun 2017 08:26:27 +0000 (10:26 +0200)
After a page read, the old failure statistics are compared against the
new failure statistics before the new values are actually read.

Signed-off-by: Harpreet "Eli" Sangha <harpreet@nestlabs.com>
Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
tests/mtd-tests/nandbiterrs.c

index 6acbfee25bc8a00deac71611b80292665d7e134e..de9d0dd8e642cdc8808d4e2f85677095adbea911 100644 (file)
@@ -268,15 +268,15 @@ static int read_page(void)
                return -1;
        }
 
+       if (ioctl(fd, ECCGETSTATS, &new) != 0)
+               goto failstats;
+
        if (new.failed > old.failed) {
                fprintf(stderr, "Failed to recover %d bitflips\n",
                                new.failed - old.failed);
                return -1;
        }
 
-       if (ioctl(fd, ECCGETSTATS, &new) != 0)
-               goto failstats;
-
        return new.corrected - old.corrected;
 failstats:
        perror("ECCGETSTATS");