]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ionic: use ee->offset when returning sprom data
authorShannon Nelson <shannon.nelson@amd.com>
Thu, 12 Dec 2024 21:31:57 +0000 (13:31 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 15 Dec 2024 22:33:31 +0000 (14:33 -0800)
Some calls into ionic_get_module_eeprom() don't use a single
full buffer size, but instead multiple calls with an offset.
Teach our driver to use the offset correctly so we can
respond appropriately to the caller.

Fixes: 4d03e00a2140 ("ionic: Add initial ethtool support")
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20241212213157.12212-4-shannon.nelson@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c

index dda22fa4448cff7f0af88640aa85f36dd770b28f..9b7f78b6cdb1e3bee4ab1a41056d0a2e6d3a0f84 100644 (file)
@@ -961,8 +961,8 @@ static int ionic_get_module_eeprom(struct net_device *netdev,
        len = min_t(u32, sizeof(xcvr->sprom), ee->len);
 
        do {
-               memcpy(data, xcvr->sprom, len);
-               memcpy(tbuf, xcvr->sprom, len);
+               memcpy(data, &xcvr->sprom[ee->offset], len);
+               memcpy(tbuf, &xcvr->sprom[ee->offset], len);
 
                /* Let's make sure we got a consistent copy */
                if (!memcmp(data, tbuf, len))