drm/amd/display: Remove useless assignments and variables

[WHAT & HOW]
misc0, temp and split_pipe are assigned but immediately re-assigned
to other values. The early assignments are useless and are removed.
Unused variables are removed as well.

This fixes 5 UNUSED_VALUE issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
index f0417ee6fcf8e8e84644193ba4dd2968c44780b9..f90fc154549a8041b1aafd24e0b2cca4f1cf8033 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
+++ b/drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
@@ -1013,7 +1013,6 @@ static bool dc_can_pipe_disable_cursor(struct pipe_ctx *pipe_ctx)
                r2 = test_pipe->plane_res.scl_data.recout;
                r2_r = r2.x + r2.width;
                r2_b = r2.y + r2.height;
-               split_pipe = test_pipe;
 
                /**
                 * There is another half plane on same layer because of

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
index 5c2825bc9a87664424444e6e006eb8bd6c328b67..d199e4ed2e59e62949d8be86ff26f643303113d8 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
@@ -277,7 +277,6 @@ static void dce110_stream_encoder_dp_set_stream_attribute(
        uint32_t misc1 = 0;
        uint32_t h_blank;
        uint32_t h_back_porch;
-       uint8_t synchronous_clock = 0; /* asynchronous mode */
        uint8_t colorimetry_bpc;
        uint8_t dynamic_range_rgb = 0; /*full range*/
        uint8_t dynamic_range_ycbcr = 1; /*bt709*/
@@ -380,7 +379,6 @@ static void dce110_stream_encoder_dp_set_stream_attribute(
                break;
        }
 
-       misc0 = misc0 | synchronous_clock;
        misc0 = colorimetry_bpc << 5;
 
        if (REG(DP_MSA_TIMING_PARAM1)) {

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
index db7557a1c6134780e0bebe3a4db24a899f1319f9..8a3fbf95c48f2a1473bca3609468aee18eeab3ee 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c
@@ -76,7 +76,6 @@ UNP_GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_C__GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_C_MAS
                mmUNP_GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_C,
                value);
 
-       temp = 0;
        value = 0;
        temp = address.low_part >>
        UNP_GRPH_PRIMARY_SURFACE_ADDRESS_C__GRPH_PRIMARY_SURFACE_ADDRESS_C__SHIFT;
@@ -112,7 +111,6 @@ UNP_GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_L__GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_L_MAS
                mmUNP_GRPH_PRIMARY_SURFACE_ADDRESS_HIGH_L,
                value);
 
-       temp = 0;
        value = 0;
        temp = address.low_part >>
        UNP_GRPH_PRIMARY_SURFACE_ADDRESS_L__GRPH_PRIMARY_SURFACE_ADDRESS_L__SHIFT;

diff --git a/drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_stream_encoder.c
index f496e952ceecb8e56c48eab3a1b403770d485321..d01a8b8f95954ececd1c0ab5ac3ad3cee62f031f 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_stream_encoder.c
@@ -255,7 +255,6 @@ void enc1_stream_encoder_dp_set_stream_attribute(
        uint32_t misc1 = 0;
        uint32_t h_blank;
        uint32_t h_back_porch;
-       uint8_t synchronous_clock = 0; /* asynchronous mode */
        uint8_t colorimetry_bpc;
        uint8_t dp_pixel_encoding = 0;
        uint8_t dp_component_depth = 0;
@@ -362,7 +361,6 @@ void enc1_stream_encoder_dp_set_stream_attribute(
                break;
        }
 
-       misc0 = misc0 | synchronous_clock;
        misc0 = colorimetry_bpc << 5;
 
        switch (output_color_space) {

diff --git a/drivers/gpu/drm/amd/display/dc/dio/dcn401/dcn401_dio_stream_encoder.c b/drivers/gpu/drm/amd/display/dc/dio/dcn401/dcn401_dio_stream_encoder.c
index 0a27e0942a12345a5715b9a5a9695be4591335dc..098c2a01a85099277cb126cc034b7c4ebac685b7 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dio/dcn401/dcn401_dio_stream_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dio/dcn401/dcn401_dio_stream_encoder.c
@@ -447,7 +447,6 @@ void enc401_stream_encoder_dp_set_stream_attribute(
        uint32_t misc1 = 0;
        uint32_t h_blank;
        uint32_t h_back_porch;
-       uint8_t synchronous_clock = 0; /* asynchronous mode */
        uint8_t colorimetry_bpc;
        uint8_t dp_pixel_encoding = 0;
        uint8_t dp_component_depth = 0;
@@ -603,7 +602,6 @@ void enc401_stream_encoder_dp_set_stream_attribute(
                break;
        }
 
-       misc0 = misc0 | synchronous_clock;
        misc0 = colorimetry_bpc << 5;
 
        switch (output_color_space) {