x86/microcode/intel: Fix a wrong assignment of revision in _save_mc

We should compare revision of saved microcode with current, or else
revision_is_newer() always return false.

Orabug: 28190263

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>

diff --git a/arch/x86/kernel/cpu/microcode/intel_early.c b/arch/x86/kernel/cpu/microcode/intel_early.c
index 2f49ab4ac0ae137d7ab0b851cf4b9e751d58922c..c157a1ebf6309b2347c8ab0fa8e04d7ab4000f94 100644 (file)
--- a/arch/x86/kernel/cpu/microcode/intel_early.c
+++ b/arch/x86/kernel/cpu/microcode/intel_early.c
@@ -255,7 +255,7 @@ static unsigned int _save_mc(struct microcode_intel **mc_saved,
                mc_saved_hdr = (struct microcode_header_intel *)mc_saved[i];
                sig          = mc_saved_hdr->sig;
                pf           = mc_saved_hdr->pf;
-               new_rev      = mc_hdr->rev;
+               new_rev      = mc_saved_hdr->rev;
 
                if (!get_matching_sig(sig, pf, new_rev, ucode_ptr))
                        continue;