]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: dsa: lantiq_gswip: Remove dead code from gswip_add_single_port_br()
authorMartin Schiller <ms@dev.tdt.de>
Tue, 11 Jun 2024 13:54:32 +0000 (15:54 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Jun 2024 00:07:11 +0000 (17:07 -0700)
The port validation in gswip_add_single_port_br() is superfluous and
can be omitted.

Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240611135434.3180973-11-ms@dev.tdt.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq_gswip.c

index cd88b00cfdc1db36063b3d75a22c92b9adc85df6..2bbc7dd45418a2a190eb9d64478b4aeaeb45a84a 100644 (file)
@@ -655,14 +655,8 @@ static int gswip_add_single_port_br(struct gswip_priv *priv, int port, bool add)
        struct gswip_pce_table_entry vlan_active = {0,};
        struct gswip_pce_table_entry vlan_mapping = {0,};
        unsigned int cpu_port = priv->hw_info->cpu_port;
-       unsigned int max_ports = priv->hw_info->max_ports;
        int err;
 
-       if (port >= max_ports) {
-               dev_err(priv->dev, "single port for %i supported\n", port);
-               return -EIO;
-       }
-
        vlan_active.index = port + 1;
        vlan_active.table = GSWIP_TABLE_ACTIVE_VLAN;
        vlan_active.key[0] = 0; /* vid */