btrfs: replace memset with memzero_page in data checksum verification

The original code resets the page to 0x1 for not apparent reason, it's
been like that since the initial 2007 code added in commit 07157aacb1ec
("Btrfs: Add file data csums back in via hooks in the extent map code").

It could mean that a failed buffer can be detected from the data but
that's just a guess and any value is good.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index b3f2010d9df5f0f31d101bb33be0e64b37be1d14..d16d1dc8f54ca687e48b2c463f9bac3670853928 100644 (file)
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -3275,11 +3275,11 @@ static int check_data_csum(struct inode *inode, struct btrfs_bio *bbio,
        shash->tfm = fs_info->csum_shash;
 
        crypto_shash_digest(shash, kaddr + pgoff, len, csum);
+       kunmap_atomic(kaddr);
 
        if (memcmp(csum, csum_expected, csum_size))
                goto zeroit;
 
-       kunmap_atomic(kaddr);
        return 0;
 zeroit:
        btrfs_print_data_csum_error(BTRFS_I(inode), start, csum, csum_expected,
@@ -3287,9 +3287,7 @@ zeroit:
        if (bbio->device)
                btrfs_dev_stat_inc_and_print(bbio->device,
                                             BTRFS_DEV_STAT_CORRUPTION_ERRS);
-       memset(kaddr + pgoff, 1, len);
-       flush_dcache_page(page);
-       kunmap_atomic(kaddr);
+       memzero_page(page, pgoff, len);
        return -EIO;
 }