]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
s390/vmem: Fix null-pointer-arithmetic warning in vmem_map_init()
authorVasily Gorbik <gor@linux.ibm.com>
Mon, 27 Jan 2025 14:23:02 +0000 (15:23 +0100)
committerAlexander Gordeev <agordeev@linux.ibm.com>
Tue, 28 Jan 2025 10:28:48 +0000 (11:28 +0100)
Fixes the following clang warning introduced by commit d7bebcb4a898
("s390: Optimize __pa/__va when RANDOMIZE_IDENTITY_BASE is off")

arch/s390/mm/vmem.c:665:36: warning: performing pointer arithmetic on
a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
  665 |                 __set_memory_4k(__va(0), __va(0) + ident_map_size);
      |                                          ~~~~~~~ ^

Fixes: d7bebcb4a898 ("s390: Optimize __pa/__va when RANDOMIZE_IDENTITY_BASE is off")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501270309.HzsVNo3o-lkp@intel.com/
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
arch/s390/mm/vmem.c

index 7c684c54e7216aae6fc02a9f4d5ab1be27766bf8..8ead999e340b6af63cb33196d113909028bde735 100644 (file)
@@ -662,7 +662,7 @@ void __init vmem_map_init(void)
        if (!static_key_enabled(&cpu_has_bear))
                set_memory_x(0, 1);
        if (debug_pagealloc_enabled())
-               __set_memory_4k(__va(0), __va(0) + ident_map_size);
+               __set_memory_4k(__va(0), absolute_pointer(__va(0)) + ident_map_size);
        pr_info("Write protected kernel read-only data: %luk\n",
                (unsigned long)(__end_rodata - _stext) >> 10);
 }