drm/amdgpu: add function to find all memory pages in one physical row

And the function can be reused across amdgpu driver.

Signed-off-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
index 64e1a3406c99e77e001ecb6f1468ee34deb947f7..984af815fb38c0d859c917e7bd582649e5a9b469 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
@@ -445,11 +445,27 @@ int amdgpu_umc_logs_ecc_err(struct amdgpu_device *adev,
        return ret;
 }
 
+int amdgpu_umc_pages_in_a_row(struct amdgpu_device *adev,
+                       struct ras_err_data *err_data, uint64_t pa_addr)
+{
+       struct ta_ras_query_address_output addr_out;
+
+       /* reinit err_data */
+       err_data->err_addr_cnt = 0;
+       err_data->err_addr_len = adev->umc.retire_unit;
+
+       addr_out.pa.pa = pa_addr;
+       if (adev->umc.ras && adev->umc.ras->convert_ras_err_addr)
+               return adev->umc.ras->convert_ras_err_addr(adev, err_data, NULL,
+                               &addr_out, false);
+       else
+               return -EINVAL;
+}
+
 int amdgpu_umc_lookup_bad_pages_in_a_row(struct amdgpu_device *adev,
                        uint64_t pa_addr, uint64_t *pfns, int len)
 {
-       uint32_t i, ret = 0, pos = 0;
-       struct ta_ras_query_address_output addr_out;
+       int i, ret;
        struct ras_err_data err_data;
 
        err_data.err_addr = kcalloc(adev->umc.retire_unit,
@@ -459,25 +475,17 @@ int amdgpu_umc_lookup_bad_pages_in_a_row(struct amdgpu_device *adev,
                return 0;
        }
 
-       addr_out.pa.pa = pa_addr;
-
-       if (adev->umc.ras && adev->umc.ras->convert_ras_err_addr) {
-               ret = adev->umc.ras->convert_ras_err_addr(adev, &err_data, NULL,
-                               &addr_out, false);
-               if (ret)
-                       goto out;
-       } else {
+       ret = amdgpu_umc_pages_in_a_row(adev, &err_data, pa_addr);
+       if (ret)
                goto out;
-       }
 
        for (i = 0; i < adev->umc.retire_unit; i++) {
-               if (pos >= len)
+               if (i >= len)
                        goto out;
 
-               pfns[pos] = err_data.err_addr[pos].retired_page;
-               pos++;
+               pfns[i] = err_data.err_addr[i].retired_page;
        }
-       ret = pos;
+       ret = i;
 
 out:
        kfree(err_data.err_addr);

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h
index f45408a6ff03fd52d09de16a32367e1511a1ef50..ce1e4fb385b5af8291c7647570c500aec84653e3 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.h
@@ -139,6 +139,8 @@ int amdgpu_umc_logs_ecc_err(struct amdgpu_device *adev,
 
 void amdgpu_umc_handle_bad_pages(struct amdgpu_device *adev,
                        void *ras_error_status);
+int amdgpu_umc_pages_in_a_row(struct amdgpu_device *adev,
+                       struct ras_err_data *err_data, uint64_t pa_addr);
 int amdgpu_umc_lookup_bad_pages_in_a_row(struct amdgpu_device *adev,
                        uint64_t pa_addr, uint64_t *pfns, int len);
 int amdgpu_umc_mca_to_addr(struct amdgpu_device *adev,