]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
phy: ti: j721e-wiz: Drop OF node reference earlier for simpler code
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 26 Aug 2024 10:07:26 +0000 (12:07 +0200)
committerVinod Koul <vkoul@kernel.org>
Fri, 30 Aug 2024 07:56:38 +0000 (13:26 +0530)
Drop OF node reference immediately after using it in
syscon_node_to_regmap(), which is both simpler and typical/expected
code pattern.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240826-phy-of-node-scope-v1-10-5b4d82582644@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-j721e-wiz.c

index bb16fdfe63dfaa56dc967c002cccf64ff5a2e603..d0f3ead3fc8056ca85437c346b3a190cf6880986 100644 (file)
@@ -1179,14 +1179,13 @@ static int wiz_clock_probe(struct wiz *wiz, struct device_node *node)
 
                ret = wiz_mux_of_clk_register(wiz, clk_node, wiz->mux_sel_field[i],
                                              clk_mux_sel[i].table);
+               of_node_put(clk_node);
                if (ret) {
                        dev_err_probe(dev, ret, "Failed to register %s clock\n",
                                      node_name);
-                       of_node_put(clk_node);
                        goto err;
                }
 
-               of_node_put(clk_node);
        }
 
        for (i = 0; i < wiz->clk_div_sel_num; i++) {
@@ -1199,14 +1198,12 @@ static int wiz_clock_probe(struct wiz *wiz, struct device_node *node)
 
                ret = wiz_div_clk_register(wiz, clk_node, wiz->div_sel_field[i],
                                           clk_div_sel[i].table);
+               of_node_put(clk_node);
                if (ret) {
                        dev_err_probe(dev, ret, "Failed to register %s clock\n",
                                      node_name);
-                       of_node_put(clk_node);
                        goto err;
                }
-
-               of_node_put(clk_node);
        }
 
        return 0;