erofs: relinquish volume with mutex held

[ Upstream commit 7032809a44d752b9e2275833787e0aa88a7540af ]

Relinquish fscache volume with mutex held.  Otherwise if a new domain is
registered when the old domain with the same name gets removed from the
list but not relinquished yet, fscache may complain the collision.

Fixes: 8b7adf1dff3d ("erofs: introduce fscache-based domain")
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Jia Zhu <zhujia.zj@bytedance.com>
Link: https://lore.kernel.org/r/20230209063913.46341-4-jefflexu@linux.alibaba.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
index b04f93bc062a811eaf6bedb8ccadd7aba168697e..076cf8a149ef3f8108cfeac3eefe5d6cddfd7675 100644 (file)
--- a/fs/erofs/fscache.c
+++ b/fs/erofs/fscache.c
@@ -398,8 +398,8 @@ static void erofs_fscache_domain_put(struct erofs_domain *domain)
                        kern_unmount(erofs_pseudo_mnt);
                        erofs_pseudo_mnt = NULL;
                }
-               mutex_unlock(&erofs_domain_list_lock);
                fscache_relinquish_volume(domain->volume, NULL, false);
+               mutex_unlock(&erofs_domain_list_lock);
                kfree(domain->domain_id);
                kfree(domain);
                return;