]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
HID: intel-thc-hid: Intel-quicki2c: Enhance driver re-install flow
authorEven Xu <even.xu@intel.com>
Wed, 6 Aug 2025 00:23:32 +0000 (08:23 +0800)
committerJiri Kosina <jkosina@suse.com>
Wed, 13 Aug 2025 11:55:38 +0000 (13:55 +0200)
After driver module is removed and during re-install stage, if there
is continueous user touching on the screen, it is a risk impacting
THC hardware initialization which causes driver installation failure.

This patch enhances this flow by quiescing the external touch
interrupt after driver is removed which keeps THC hardware
ignore external interrupt during this remove and re-install stage.

Signed-off-by: Even Xu <even.xu@intel.com>
Tested-by: Rui Zhang <rui1.zhang@intel.com>
Fixes: 66b59bfce6d9 ("HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver")
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c

index e944a6ccb776cc73ca0a2d9c0fd82572699b9a7a..854926b3cfd4554c2dd33268b3d6ce8ce2be69d8 100644 (file)
@@ -419,6 +419,7 @@ static struct quicki2c_device *quicki2c_dev_init(struct pci_dev *pdev, void __io
  */
 static void quicki2c_dev_deinit(struct quicki2c_device *qcdev)
 {
+       thc_interrupt_quiesce(qcdev->thc_hw, true);
        thc_interrupt_enable(qcdev->thc_hw, false);
        thc_ltr_unconfig(qcdev->thc_hw);
        thc_wot_unconfig(qcdev->thc_hw);