]> www.infradead.org Git - users/hch/misc.git/commitdiff
ipmi: kcs: Finish configuring ASPEED KCS device before enable
authorAndrew Jeffery <andrew@aj.id.au>
Mon, 16 Dec 2019 02:27:41 +0000 (12:57 +1030)
committerCorey Minyard <cminyard@mvista.com>
Fri, 3 Apr 2020 13:05:05 +0000 (08:05 -0500)
The interrupts were configured after the channel was enabled. Configure
them beforehand so they will work.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
Message-Id: <c0aba2c9dfe2d0525e9cefd37995983ead0ec242.1576462051.git-series.andrew@aj.id.au>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/kcs_bmc_aspeed.c

index 3c955946e6477ded031e4f40d5e64b93171d0150..e3dd09022589c5e7f671b265e959b5ee9c50cbbb 100644 (file)
@@ -268,13 +268,14 @@ static int aspeed_kcs_probe(struct platform_device *pdev)
        kcs_bmc->io_inputb = aspeed_kcs_inb;
        kcs_bmc->io_outputb = aspeed_kcs_outb;
 
+       rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
+       if (rc)
+               return rc;
+
        dev_set_drvdata(dev, kcs_bmc);
 
        aspeed_kcs_set_address(kcs_bmc, addr);
        aspeed_kcs_enable_channel(kcs_bmc, true);
-       rc = aspeed_kcs_config_irq(kcs_bmc, pdev);
-       if (rc)
-               return rc;
 
        rc = misc_register(&kcs_bmc->miscdev);
        if (rc) {