HID: rmi: fix some harmless BIT() mistakes

These defines are used like this:

	if (!(test_bit(RMI_STARTED, &hdata->flags)))

So the intent was to use bits 0, 1 and 2 but because of the extra BIT()
shifts we're actually using 1, 2 and 4.  It's harmless because it's done
consistently but static checkers will complain.

Fixes: 9fb6bf02e3ad ('HID: rmi: introduce RMI driver for Synaptics touchpads')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 368ffdf2c0a3af086d9242f00476f598a3fffdf9..2f3e51d45f0c7671858f63431a9efb4a090a3b11 100644 (file)
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -29,9 +29,9 @@
 #define RMI_SET_RMI_MODE_REPORT_ID     0x0f /* Feature Report */
 
 /* flags */
-#define RMI_READ_REQUEST_PENDING       BIT(0)
-#define RMI_READ_DATA_PENDING          BIT(1)
-#define RMI_STARTED                    BIT(2)
+#define RMI_READ_REQUEST_PENDING       0
+#define RMI_READ_DATA_PENDING          1
+#define RMI_STARTED                    2
 
 /* device flags */
 #define RMI_DEVICE                     BIT(0)