ubiformat: don't leak file descriptors

The original code had a 'goto out_close' directly after a return error
code, which is obviously not what was intended.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>

diff --git a/ubi-utils/ubiformat.c b/ubi-utils/ubiformat.c
index a90627c9c479d3f09aaa670ec7edb0e21ca4d9d7..64afad24ec32c8d066ab1819c57a6b5183deb274 100644 (file)
--- a/ubi-utils/ubiformat.c
+++ b/ubi-utils/ubiformat.c
@@ -426,8 +426,8 @@ static int flash_image(libmtd_t libmtd, const struct mtd_dev_info *mtd,
        }
 
        if (st_size % mtd->eb_size) {
-               return sys_errmsg("file \"%s\" (size %lld bytes) is not multiple of ""eraseblock size (%d bytes)",
-                                 args.image, (long long)st_size, mtd->eb_size);
+               sys_errmsg("file \"%s\" (size %lld bytes) is not multiple of ""eraseblock size (%d bytes)",
+                         args.image, (long long)st_size, mtd->eb_size);
                goto out_close;
        }