]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
mm/damon/sysfs-schemes: handle tried region directory allocation failure
authorSeongJae Park <sj@kernel.org>
Mon, 6 Nov 2023 23:34:08 +0000 (23:34 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 15 Nov 2023 23:30:09 +0000 (15:30 -0800)
DAMON sysfs interface's before_damos_apply callback
(damon_sysfs_before_damos_apply()), which creates the DAMOS tried regions
for each DAMOS action applied region, is not handling the allocation
failure for the sysfs directory data.  As a result, NULL pointer
derefeence is possible.  Fix it by handling the case.

Link: https://lkml.kernel.org/r/20231106233408.51159-4-sj@kernel.org
Fixes: f1d13cacabe1 ("mm/damon/sysfs: implement DAMOS tried regions update command")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [6.2+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs-schemes.c

index 7413cb35c5a9c43c5801215e760c62d4fcf3e68a..be667236b8e6e30713a205a4987d50c3b48ab463 100644 (file)
@@ -1826,6 +1826,8 @@ static int damon_sysfs_before_damos_apply(struct damon_ctx *ctx,
                return 0;
 
        region = damon_sysfs_scheme_region_alloc(r);
+       if (!region)
+               return 0;
        list_add_tail(&region->list, &sysfs_regions->regions_list);
        sysfs_regions->nr_regions++;
        if (kobject_init_and_add(&region->kobj,