Input: cyttsp - use devm_regulator_bulk_get_enable()

The driver does not try to power down the rails at system suspend or
when touchscreen is not in use, but rather enables regulators at probe
time. Power savings are achieved by requesting the controller to enter
low power mode.

Switch to devm_regulator_bulk_get_enable() instead of separately
requesting regulators, enabling them, and installing a custom
devm-action to disable them on unbind/remove, which simplifies the
code.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/ZrAgj9rG6oVqfdoK@google.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index 3e77cca4f5ca53bc6e6edfd3ce270ddae6328f26..b8ce6012364cfee0eb94663d1c9b86e1d588d3c9 100644 (file)
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -614,17 +614,14 @@ static int cyttsp_parse_properties(struct cyttsp *ts)
        return 0;
 }
 
-static void cyttsp_disable_regulators(void *_ts)
-{
-       struct cyttsp *ts = _ts;
-
-       regulator_bulk_disable(ARRAY_SIZE(ts->regulators),
-                              ts->regulators);
-}
-
 struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
                            struct device *dev, int irq, size_t xfer_buf_size)
 {
+       /*
+        * VCPIN is the analog voltage supply
+        * VDD is the digital voltage supply
+        */
+       static const char * const supplies[] = { "vcpin", "vdd" };
        struct cyttsp *ts;
        struct input_dev *input_dev;
        int error;
@@ -642,29 +639,10 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
        ts->bus_ops = bus_ops;
        ts->irq = irq;
 
-       /*
-        * VCPIN is the analog voltage supply
-        * VDD is the digital voltage supply
-        */
-       ts->regulators[0].supply = "vcpin";
-       ts->regulators[1].supply = "vdd";
-       error = devm_regulator_bulk_get(dev, ARRAY_SIZE(ts->regulators),
-                                       ts->regulators);
-       if (error) {
-               dev_err(dev, "Failed to get regulators: %d\n", error);
-               return ERR_PTR(error);
-       }
-
-       error = regulator_bulk_enable(ARRAY_SIZE(ts->regulators),
-                                     ts->regulators);
-       if (error) {
-               dev_err(dev, "Cannot enable regulators: %d\n", error);
-               return ERR_PTR(error);
-       }
-
-       error = devm_add_action_or_reset(dev, cyttsp_disable_regulators, ts);
+       error = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(supplies),
+                                              supplies);
        if (error) {
-               dev_err(dev, "failed to install chip disable handler\n");
+               dev_err(dev, "Failed to enable regulators: %d\n", error);
                return ERR_PTR(error);
        }
 

diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h
index 075509e695a276ed5c798af9aea099708e7080ee..cd3b80401970e7dc7987a3613695ad04d622d64b 100644 (file)
--- a/drivers/input/touchscreen/cyttsp_core.h
+++ b/drivers/input/touchscreen/cyttsp_core.h
@@ -122,7 +122,6 @@ struct cyttsp {
        enum cyttsp_state state;
        bool suspended;
 
-       struct regulator_bulk_data regulators[2];
        struct gpio_desc *reset_gpio;
        bool use_hndshk;
        u8 act_dist;