nfsd: don't take/put an extra reference when putting a file

[ Upstream commit b2ff1bd71db2a1b193a6dde0845adcd69cbcf75e ]

The last thing that filp_close does is an fput, so don't bother taking
and putting the extra reference.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index faa0c7d0253ebfd5ae48a8b1b47a229f73c5dfc2..786e06cf107ffd17891d5f661498ec1071bf5cb0 100644 (file)
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -381,10 +381,8 @@ nfsd_file_free(struct nfsd_file *nf)
        if (nf->nf_mark)
                nfsd_file_mark_put(nf->nf_mark);
        if (nf->nf_file) {
-               get_file(nf->nf_file);
-               filp_close(nf->nf_file, NULL);
                nfsd_file_check_write_error(nf);
-               fput(nf->nf_file);
+               filp_close(nf->nf_file, NULL);
        }
 
        /*