soundwire: cadence: remove automatic command retries

This is a good idea on paper, but it's not recommended at all when
operating in multi-master mode. It's also not recommended when doing
bank switches, since the retransmission would happen at the next SSP,
and the command protocol is stuck in the mean time.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200317163329.25501-15-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
index 420ad23c553077ddd9c0629ab14a08d9db0cc849..c9fdd4deb4f5e3167649983520327cc1569f373e 100644 (file)
--- a/drivers/soundwire/cadence_master.c
+++ b/drivers/soundwire/cadence_master.c
@@ -1109,8 +1109,7 @@ int sdw_cdns_init(struct sdw_cdns *cdns)
 
        /* leave frame delay to hardware default of 0x1F */
 
-       /* Set Max cmd retry to 15 */
-       val |= CDNS_MCP_CONFIG_MCMD_RETRY;
+       /* leave command retry to hardware default of 0 */
 
        cdns_writel(cdns, CDNS_MCP_CONFIG, val);