wifi: ath12k: add processing for TWT disable event

When ath12k send TWT disable command to firmware, firmware will return a
TWT disable event to ath12k. Through the analysis of TWT disable event
status, we can easily obtain the status of TWT disable command. It can be
more convenient to debug TWT.

This patch works with WCN7850 and QCN9274.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4

Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20240122085336.3985-3-quic_lingbok@quicinc.com

diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
index 7d65dff7ab1ec1c1d39a0e48544d36745e9c93cf..5acbed4f64f25c931cc4d4956867545da76880c4 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/wmi.c
+++ b/drivers/net/wireless/ath/ath12k/wmi.c
@@ -164,6 +164,8 @@ static const struct ath12k_wmi_tlv_policy ath12k_wmi_tlv_policies[] = {
                .min_len = sizeof(struct wmi_vdev_delete_resp_event) },
        [WMI_TAG_TWT_ENABLE_COMPLETE_EVENT] = {
                .min_len = sizeof(struct wmi_twt_enable_event) },
+       [WMI_TAG_TWT_DISABLE_COMPLETE_EVENT] = {
+               .min_len = sizeof(struct wmi_twt_disable_event) },
 };
 
 static __le32 ath12k_wmi_tlv_hdr(u32 cmd, u32 len)
@@ -6700,6 +6702,35 @@ exit:
        kfree(tb);
 }
 
+static void ath12k_wmi_twt_disable_event(struct ath12k_base *ab,
+                                        struct sk_buff *skb)
+{
+       const void **tb;
+       const struct wmi_twt_disable_event *ev;
+       int ret;
+
+       tb = ath12k_wmi_tlv_parse_alloc(ab, skb, GFP_ATOMIC);
+       if (IS_ERR(tb)) {
+               ret = PTR_ERR(tb);
+               ath12k_warn(ab, "failed to parse wmi twt disable status event tlv: %d\n",
+                           ret);
+               return;
+       }
+
+       ev = tb[WMI_TAG_TWT_DISABLE_COMPLETE_EVENT];
+       if (!ev) {
+               ath12k_warn(ab, "failed to fetch twt disable wmi event\n");
+               goto exit;
+       }
+
+       ath12k_dbg(ab, ATH12K_DBG_MAC, "wmi twt disable event pdev id %d status %u\n",
+                  le32_to_cpu(ev->pdev_id),
+                  le32_to_cpu(ev->status));
+
+exit:
+       kfree(tb);
+}
+
 static void ath12k_wmi_op_rx(struct ath12k_base *ab, struct sk_buff *skb)
 {
        struct wmi_cmd_hdr *cmd_hdr;
@@ -6798,10 +6829,12 @@ static void ath12k_wmi_op_rx(struct ath12k_base *ab, struct sk_buff *skb)
        case WMI_TWT_ENABLE_EVENTID:
                ath12k_wmi_twt_enable_event(ab, skb);
                break;
+       case WMI_TWT_DISABLE_EVENTID:
+               ath12k_wmi_twt_disable_event(ab, skb);
+               break;
        /* add Unsupported events here */
        case WMI_TBTTOFFSET_EXT_UPDATE_EVENTID:
        case WMI_PEER_OPER_MODE_CHANGE_EVENTID:
-       case WMI_TWT_DISABLE_EVENTID:
        case WMI_PDEV_DMA_RING_CFG_RSP_EVENTID:
                ath12k_dbg(ab, ATH12K_DBG_WMI,
                           "ignoring unsupported event 0x%x\n", id);

diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index 0819f16b09f6ae5ea3c83ee1af10c22a368e11b2..dceb55ca153afefd18fe3b7e0cf09fb557601a12 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -4814,6 +4814,11 @@ struct wmi_twt_enable_event {
        __le32 status;
 } __packed;
 
+struct wmi_twt_disable_event {
+       __le32 pdev_id;
+       __le32 status;
+} __packed;
+
 void ath12k_wmi_init_qcn9274(struct ath12k_base *ab,
                             struct ath12k_wmi_resource_config_arg *config);
 void ath12k_wmi_init_wcn7850(struct ath12k_base *ab,