bpf: Allow numa selection in INNER_LRU_HASH_PREALLOC test of map_perf_test

This patch makes the needed changes to allow each process of
the INNER_LRU_HASH_PREALLOC test to provide its numa node id
when creating the lru map.

Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Alexei Starovoitov <ast@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c
index a8552b8a2ab6e770c25ef4351f48cc1768dd1e81..6aa50098dfb8e177bd6c74c550a5aac2213148f1 100644 (file)
--- a/samples/bpf/bpf_load.c
+++ b/samples/bpf/bpf_load.c
@@ -201,7 +201,7 @@ static int load_and_attach(const char *event, struct bpf_insn *prog, int size)
 static int load_maps(struct bpf_map_data *maps, int nr_maps,
                     fixup_map_cb fixup_map)
 {
-       int i;
+       int i, numa_node;
 
        for (i = 0; i < nr_maps; i++) {
                if (fixup_map) {
@@ -213,21 +213,26 @@ static int load_maps(struct bpf_map_data *maps, int nr_maps,
                        }
                }
 
+               numa_node = maps[i].def.map_flags & BPF_F_NUMA_NODE ?
+                       maps[i].def.numa_node : -1;
+
                if (maps[i].def.type == BPF_MAP_TYPE_ARRAY_OF_MAPS ||
                    maps[i].def.type == BPF_MAP_TYPE_HASH_OF_MAPS) {
                        int inner_map_fd = map_fd[maps[i].def.inner_map_idx];
 
-                       map_fd[i] = bpf_create_map_in_map(maps[i].def.type,
+                       map_fd[i] = bpf_create_map_in_map_node(maps[i].def.type,
                                                        maps[i].def.key_size,
                                                        inner_map_fd,
                                                        maps[i].def.max_entries,
-                                                       maps[i].def.map_flags);
+                                                       maps[i].def.map_flags,
+                                                       numa_node);
                } else {
-                       map_fd[i] = bpf_create_map(maps[i].def.type,
-                                                  maps[i].def.key_size,
-                                                  maps[i].def.value_size,
-                                                  maps[i].def.max_entries,
-                                                  maps[i].def.map_flags);
+                       map_fd[i] = bpf_create_map_node(maps[i].def.type,
+                                                       maps[i].def.key_size,
+                                                       maps[i].def.value_size,
+                                                       maps[i].def.max_entries,
+                                                       maps[i].def.map_flags,
+                                                       numa_node);
                }
                if (map_fd[i] < 0) {
                        printf("failed to create a map: %d %s\n",

diff --git a/samples/bpf/bpf_load.h b/samples/bpf/bpf_load.h
index ca0563d04744fe31a472b53824a5a1135b53be48..453e3226b4ceb1ac91c96fa761a9402399dce8e1 100644 (file)
--- a/samples/bpf/bpf_load.h
+++ b/samples/bpf/bpf_load.h
@@ -13,6 +13,7 @@ struct bpf_map_def {
        unsigned int max_entries;
        unsigned int map_flags;
        unsigned int inner_map_idx;
+       unsigned int numa_node;
 };
 
 struct bpf_map_data {

diff --git a/samples/bpf/map_perf_test_kern.c b/samples/bpf/map_perf_test_kern.c
index 245165817fbe63bd53ea9cf7f3a3ab6cf5e7a2fa..ca3b22ed577a3f016b861272f9a3166e5909347d 100644 (file)
--- a/samples/bpf/map_perf_test_kern.c
+++ b/samples/bpf/map_perf_test_kern.c
@@ -40,6 +40,8 @@ struct bpf_map_def SEC("maps") inner_lru_hash_map = {
        .key_size = sizeof(u32),
        .value_size = sizeof(long),
        .max_entries = MAX_ENTRIES,
+       .map_flags = BPF_F_NUMA_NODE,
+       .numa_node = 0,
 };
 
 struct bpf_map_def SEC("maps") array_of_lru_hashs = {

diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c
index 1a8894b5ac5147c36833ffae500ddfbeb00277d1..bccbf8478e43d15b51e8ac6b6844d05cca18403c 100644 (file)
--- a/samples/bpf/map_perf_test_user.c
+++ b/samples/bpf/map_perf_test_user.c
@@ -97,14 +97,20 @@ static void do_test_lru(enum test_type test, int cpu)
 
        if (test == INNER_LRU_HASH_PREALLOC) {
                int outer_fd = map_fd[array_of_lru_hashs_idx];
+               unsigned int mycpu, mynode;
 
                assert(cpu < MAX_NR_CPUS);
 
                if (cpu) {
+                       ret = syscall(__NR_getcpu, &mycpu, &mynode, NULL);
+                       assert(!ret);
+
                        inner_lru_map_fds[cpu] =
-                               bpf_create_map(BPF_MAP_TYPE_LRU_HASH,
-                                              sizeof(uint32_t), sizeof(long),
-                                              inner_lru_hash_size, 0);
+                               bpf_create_map_node(BPF_MAP_TYPE_LRU_HASH,
+                                                   sizeof(uint32_t),
+                                                   sizeof(long),
+                                                   inner_lru_hash_size, 0,
+                                                   mynode);
                        if (inner_lru_map_fds[cpu] == -1) {
                                printf("cannot create BPF_MAP_TYPE_LRU_HASH %s(%d)\n",
                                       strerror(errno), errno);

diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 2d97dd27c8f64f5e6162472aae9b70eea58f1dda..f8f6377fd54109c3826fee96508ce45c7d5a2b8e 100644 (file)
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -168,6 +168,7 @@ enum bpf_sockmap_flags {
 #define BPF_NOEXIST    1 /* create new element if it didn't exist */
 #define BPF_EXIST      2 /* update existing element */
 
+/* flags for BPF_MAP_CREATE command */
 #define BPF_F_NO_PREALLOC      (1U << 0)
 /* Instead of having one common LRU list in the
  * BPF_MAP_TYPE_LRU_[PERCPU_]HASH map, use a percpu LRU list
@@ -176,6 +177,8 @@ enum bpf_sockmap_flags {
  * across different LRU lists.
  */
 #define BPF_F_NO_COMMON_LRU    (1U << 1)
+/* Specify numa node during map creation */
+#define BPF_F_NUMA_NODE                (1U << 2)
 
 union bpf_attr {
        struct { /* anonymous struct used by BPF_MAP_CREATE command */
@@ -183,8 +186,13 @@ union bpf_attr {
                __u32   key_size;       /* size of key in bytes */
                __u32   value_size;     /* size of value in bytes */
                __u32   max_entries;    /* max number of entries in a map */
-               __u32   map_flags;      /* prealloc or not */
+               __u32   map_flags;      /* BPF_MAP_CREATE related
+                                        * flags defined above.
+                                        */
                __u32   inner_map_fd;   /* fd pointing to the inner map */
+               __u32   numa_node;      /* numa node (effective only if
+                                        * BPF_F_NUMA_NODE is set).
+                                        */
        };
 
        struct { /* anonymous struct used by BPF_MAP_*_ELEM commands */

diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
index 77660157a68445edb7cb0e82ce239f5eafec9822..a0717610b116f0ee171b3c846eecc0b738111109 100644 (file)
--- a/tools/lib/bpf/bpf.c
+++ b/tools/lib/bpf/bpf.c
@@ -57,8 +57,9 @@ static inline int sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr,
        return syscall(__NR_bpf, cmd, attr, size);
 }
 
-int bpf_create_map(enum bpf_map_type map_type, int key_size,
-                  int value_size, int max_entries, __u32 map_flags)
+int bpf_create_map_node(enum bpf_map_type map_type, int key_size,
+                       int value_size, int max_entries, __u32 map_flags,
+                       int node)
 {
        union bpf_attr attr;
 
@@ -69,12 +70,24 @@ int bpf_create_map(enum bpf_map_type map_type, int key_size,
        attr.value_size = value_size;
        attr.max_entries = max_entries;
        attr.map_flags = map_flags;
+       if (node >= 0) {
+               attr.map_flags |= BPF_F_NUMA_NODE;
+               attr.numa_node = node;
+       }
 
        return sys_bpf(BPF_MAP_CREATE, &attr, sizeof(attr));
 }
 
-int bpf_create_map_in_map(enum bpf_map_type map_type, int key_size,
-                         int inner_map_fd, int max_entries, __u32 map_flags)
+int bpf_create_map(enum bpf_map_type map_type, int key_size,
+                  int value_size, int max_entries, __u32 map_flags)
+{
+       return bpf_create_map_node(map_type, key_size, value_size,
+                                  max_entries, map_flags, -1);
+}
+
+int bpf_create_map_in_map_node(enum bpf_map_type map_type, int key_size,
+                              int inner_map_fd, int max_entries,
+                              __u32 map_flags, int node)
 {
        union bpf_attr attr;
 
@@ -86,10 +99,21 @@ int bpf_create_map_in_map(enum bpf_map_type map_type, int key_size,
        attr.inner_map_fd = inner_map_fd;
        attr.max_entries = max_entries;
        attr.map_flags = map_flags;
+       if (node >= 0) {
+               attr.map_flags |= BPF_F_NUMA_NODE;
+               attr.numa_node = node;
+       }
 
        return sys_bpf(BPF_MAP_CREATE, &attr, sizeof(attr));
 }
 
+int bpf_create_map_in_map(enum bpf_map_type map_type, int key_size,
+                         int inner_map_fd, int max_entries, __u32 map_flags)
+{
+       return bpf_create_map_in_map_node(map_type, key_size, inner_map_fd,
+                                         max_entries, map_flags, -1);
+}
+
 int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
                     size_t insns_cnt, const char *license,
                     __u32 kern_version, char *log_buf, size_t log_buf_sz)

diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
index eaee585c1cead0fb7b8956859f49f107bf952b91..90e9d4e85d086d4e69f4cb6ef400fb4cc27a2e5a 100644 (file)
--- a/tools/lib/bpf/bpf.h
+++ b/tools/lib/bpf/bpf.h
@@ -24,8 +24,14 @@
 #include <linux/bpf.h>
 #include <stddef.h>
 
+int bpf_create_map_node(enum bpf_map_type map_type, int key_size,
+                       int value_size, int max_entries, __u32 map_flags,
+                       int node);
 int bpf_create_map(enum bpf_map_type map_type, int key_size, int value_size,
                   int max_entries, __u32 map_flags);
+int bpf_create_map_in_map_node(enum bpf_map_type map_type, int key_size,
+                              int inner_map_fd, int max_entries,
+                              __u32 map_flags, int node);
 int bpf_create_map_in_map(enum bpf_map_type map_type, int key_size,
                          int inner_map_fd, int max_entries, __u32 map_flags);
 

diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h
index 73092d4a898ed14d908199e1a8ae869bea205aab..98f3be26d390247d4c8c00eff7085b0fef25760c 100644 (file)
--- a/tools/testing/selftests/bpf/bpf_helpers.h
+++ b/tools/testing/selftests/bpf/bpf_helpers.h
@@ -94,6 +94,7 @@ struct bpf_map_def {
        unsigned int max_entries;
        unsigned int map_flags;
        unsigned int inner_map_idx;
+       unsigned int numa_node;
 };
 
 static int (*bpf_skb_load_bytes)(void *ctx, int off, void *to, int len) =