Fix a potential abuse of seq_printf() format string in drivers

Using device name as format string of seq_printf() is proned to
"Format string attack", opens possibility for exploitation.
Seq_puts() is safer and more efficient.

Signed-off-by: David Wang <00107082@163.com>
Reviewed-by: Kees Cook <kees@kernel.org>
Link: https://lore.kernel.org/r/20241120053055.225195-1-00107082@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpio/gpio-aspeed-sgpio.c b/drivers/gpio/gpio-aspeed-sgpio.c
index 72755fee647847d643ac209e1d52b0f71e1fac8e..34eb26298e32412c3cf8533b4b5855676f5f98ba 100644 (file)
--- a/drivers/gpio/gpio-aspeed-sgpio.c
+++ b/drivers/gpio/gpio-aspeed-sgpio.c
@@ -420,7 +420,7 @@ static void aspeed_sgpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
        int offset;
 
        irqd_to_aspeed_sgpio_data(d, &gpio, &bank, &bit, &offset);
-       seq_printf(p, dev_name(gpio->dev));
+       seq_puts(p, dev_name(gpio->dev));
 }
 
 static const struct irq_chip aspeed_sgpio_irq_chip = {

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index ea40ad43a79baacd0fd971cebbd4a627d4e9f0a3..7f3292d9f016cb632862194ee1c0900aa71b5808 100644 (file)
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1102,7 +1102,7 @@ static void aspeed_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
        if (rc)
                return;
 
-       seq_printf(p, dev_name(gpio->dev));
+       seq_puts(p, dev_name(gpio->dev));
 }
 
 static const struct irq_chip aspeed_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index ab798c848215ad9241ccb39d82f0e5d27fed09c5..58d2464c07bc360137f3100de4e4147030bb121c 100644 (file)
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -249,7 +249,7 @@ static void ep93xx_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-       seq_printf(p, dev_name(gc->parent));
+       seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip gpio_eic_irq_chip = {

diff --git a/drivers/gpio/gpio-hlwd.c b/drivers/gpio/gpio-hlwd.c
index 1bcfc1835dae8c70a28b54b2a0a5ca493e2872bd..0580f6712bea9a4d510bd332645982adbc5c6a32 100644 (file)
--- a/drivers/gpio/gpio-hlwd.c
+++ b/drivers/gpio/gpio-hlwd.c
@@ -210,7 +210,7 @@ static void hlwd_gpio_irq_print_chip(struct irq_data *data, struct seq_file *p)
        struct hlwd_gpio *hlwd =
                gpiochip_get_data(irq_data_get_irq_chip_data(data));
 
-       seq_printf(p, dev_name(hlwd->dev));
+       seq_puts(p, dev_name(hlwd->dev));
 }
 
 static const struct irq_chip hlwd_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c
index 6abe01bc39c3e1123440bca8034e826b27419f5e..6f3dda6b635fa2c0d51fea16b26f78e1aa3167b4 100644 (file)
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -331,7 +331,7 @@ static void mlxbf2_gpio_irq_print_chip(struct irq_data *irqd,
        struct gpio_chip *gc = irq_data_get_irq_chip_data(irqd);
        struct mlxbf2_gpio_context *gs = gpiochip_get_data(gc);
 
-       seq_printf(p, dev_name(gs->dev));
+       seq_puts(p, dev_name(gs->dev));
 }
 
 static const struct irq_chip mlxbf2_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 76d5d87e9681ebdf3e51653408a7e05ac8db903f..279524b640ae44dda0ef475fa87a7b43c7c1391e 100644 (file)
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -715,7 +715,7 @@ static void omap_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
        struct gpio_bank *bank = omap_irq_data_get_bank(d);
 
-       seq_printf(p, dev_name(bank->dev));
+       seq_puts(p, dev_name(bank->dev));
 }
 
 static const struct irq_chip omap_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 3f2d33ee20cca9c8cb04956cdd24efab0767ea10..272febc3230e90baf370811f498383b9fb12cc6f 100644 (file)
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -815,7 +815,7 @@ static void pca953x_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-       seq_printf(p, dev_name(gc->parent));
+       seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip pca953x_irq_chip = {

diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
index a211a02d4b4a633e81ffda19ca437f52d79f9bf5..1c273727ffa3ac54d0f1e66bd6efb784d2a8604e 100644 (file)
--- a/drivers/gpio/gpio-pl061.c
+++ b/drivers/gpio/gpio-pl061.c
@@ -291,7 +291,7 @@ static void pl061_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-       seq_printf(p, dev_name(gc->parent));
+       seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip pl061_irq_chip = {

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 6d3a39a03f58e22363f69a3c9074021c1107fc32..9ad286adf2632f300ee981185ea32d79ca012df5 100644 (file)
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -600,7 +600,7 @@ static void tegra_gpio_irq_print_chip(struct irq_data *d, struct seq_file *s)
 {
        struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
 
-       seq_printf(s, dev_name(chip->parent));
+       seq_puts(s, dev_name(chip->parent));
 }
 
 static const struct irq_chip tegra_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
index 1ecb733a5e88b4ade2b46f9089d672ec5ce07a60..6895b65c86aff5b92bee2da0ad5f3306653828e6 100644 (file)
--- a/drivers/gpio/gpio-tegra186.c
+++ b/drivers/gpio/gpio-tegra186.c
@@ -610,7 +610,7 @@ static void tegra186_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-       seq_printf(p, dev_name(gc->parent));
+       seq_puts(p, dev_name(gc->parent));
 }
 
 static const struct irq_chip tegra186_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
index f2e7e8754d95d699c0c2e4aa334e362396c376f4..5e26eb3adabbf4f467a27892882b803c62c43414 100644 (file)
--- a/drivers/gpio/gpio-tqmx86.c
+++ b/drivers/gpio/gpio-tqmx86.c
@@ -275,7 +275,7 @@ static void tqmx86_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
 
-       seq_printf(p, gc->label);
+       seq_puts(p, gc->label);
 }
 
 static const struct irq_chip tqmx86_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-visconti.c b/drivers/gpio/gpio-visconti.c
index ebc71ecdb6cf5d0adfbddad5c86f60648d29e79f..5bd965c18a465f29884cbe56711b25d7e755df2d 100644 (file)
--- a/drivers/gpio/gpio-visconti.c
+++ b/drivers/gpio/gpio-visconti.c
@@ -142,7 +142,7 @@ static void visconti_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct visconti_gpio *priv = gpiochip_get_data(gc);
 
-       seq_printf(p, dev_name(priv->dev));
+       seq_puts(p, dev_name(priv->dev));
 }
 
 static const struct irq_chip visconti_gpio_irq_chip = {

diff --git a/drivers/gpio/gpio-xgs-iproc.c b/drivers/gpio/gpio-xgs-iproc.c
index d445eea036879673d2cf793ab05837dce567639a..e9390f136b3c6637fc6b6184fe33b34fcefefa00 100644 (file)
--- a/drivers/gpio/gpio-xgs-iproc.c
+++ b/drivers/gpio/gpio-xgs-iproc.c
@@ -198,7 +198,7 @@ static void iproc_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct iproc_gpio_chip *chip = to_iproc_gpio(gc);
 
-       seq_printf(p, dev_name(chip->dev));
+       seq_puts(p, dev_name(chip->dev));
 }
 
 static const struct irq_chip iproc_gpio_irq_chip = {

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 3be7bd8cd8cdeb6d03a0f03bd99235375c1dadf0..8fae6dc010241e10b9eef9bec40b1661e4e9e698 100644 (file)
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -400,7 +400,7 @@ static void gic_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gic_chip_data *gic = irq_data_get_irq_chip_data(d);
 
        if (gic->domain->pm_dev)
-               seq_printf(p, gic->domain->pm_dev->of_node->name);
+               seq_puts(p, gic->domain->pm_dev->of_node->name);
        else
                seq_printf(p, "GIC-%d", (int)(gic - &gic_data[0]));
 }

diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c
index 08b0cc862adf03eccab646ac62bf26d4e3ec941b..b815a60f930c979bfc6eac48f9609ce920b0b7fc 100644 (file)
--- a/drivers/irqchip/irq-mvebu-pic.c
+++ b/drivers/irqchip/irq-mvebu-pic.c
@@ -71,7 +71,7 @@ static void mvebu_pic_print_chip(struct irq_data *d, struct seq_file *p)
 {
        struct mvebu_pic *pic = irq_data_get_irq_chip_data(d);
 
-       seq_printf(p, dev_name(&pic->pdev->dev));
+       seq_puts(p, dev_name(&pic->pdev->dev));
 }
 
 static const struct irq_chip mvebu_pic_chip = {

diff --git a/drivers/irqchip/irq-versatile-fpga.c b/drivers/irqchip/irq-versatile-fpga.c
index ca471c6fee998b239f0ab32378b5bbfababf1b31..0abc8934c2ee00e4077c1dddb867141d4a008ea5 100644 (file)
--- a/drivers/irqchip/irq-versatile-fpga.c
+++ b/drivers/irqchip/irq-versatile-fpga.c
@@ -69,7 +69,7 @@ static void fpga_irq_print_chip(struct irq_data *d, struct seq_file *p)
 {
        struct fpga_irq_data *f = irq_data_get_irq_chip_data(d);
 
-       seq_printf(p, irq_domain_get_of_node(f->domain)->name);
+       seq_puts(p, irq_domain_get_of_node(f->domain)->name);
 }
 
 static const struct irq_chip fpga_chip = {

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index fd5ce52d05b1d40c57a0f6cfe84546256ed061e0..c9a3d3aa8c108663109e22b2dd88f7151c2588f3 100644 (file)
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -309,7 +309,7 @@ static void iproc_gpio_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct iproc_gpio *chip = gpiochip_get_data(gc);
 
-       seq_printf(p, dev_name(chip->dev));
+       seq_puts(p, dev_name(chip->dev));
 }
 
 static const struct irq_chip iproc_gpio_irq_chip = {

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 4c4ada06423d7242bb9f3ae86380257fbbdc328f..335744ac831057576473dd62c5533168b243a656 100644 (file)
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -734,7 +734,7 @@ static void armada_37xx_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *chip = irq_data_get_irq_chip_data(d);
        struct armada_37xx_pinctrl *info = gpiochip_get_data(chip);
 
-       seq_printf(p, info->data->name);
+       seq_puts(p, info->data->name);
 }
 
 static const struct irq_chip armada_37xx_irqchip = {

diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index 737d0ae3d0b66266c4c46db8733eb96944689ece..d66c3a3e842924ba96adaed970a2bf1419c3c9b2 100644 (file)
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -569,7 +569,7 @@ static void mcp23s08_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct mcp23s08 *mcp = gpiochip_get_data(gc);
 
-       seq_printf(p, dev_name(mcp->dev));
+       seq_puts(p, dev_name(mcp->dev));
 }
 
 static const struct irq_chip mcp23s08_irq_chip = {

diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index d2c5321dd025f87493440955fd69c834aabf698f..31d68183b743b41d5ff4c6a5f853d3e01eef88e9 100644 (file)
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -599,7 +599,7 @@ static void stmfx_pinctrl_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gpio_chip = irq_data_get_irq_chip_data(d);
        struct stmfx_pinctrl *pctl = gpiochip_get_data(gpio_chip);
 
-       seq_printf(p, dev_name(pctl->dev));
+       seq_puts(p, dev_name(pctl->dev));
 }
 
 static const struct irq_chip stmfx_pinctrl_irq_chip = {

diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
index fd0331a87cda2131aaf8d49df3d0911eaa060aaa..dbe14566e1f3c96b62828d53689b3cbd9b724633 100644 (file)
--- a/drivers/pinctrl/pinctrl-sx150x.c
+++ b/drivers/pinctrl/pinctrl-sx150x.c
@@ -584,7 +584,7 @@ static void sx150x_irq_print_chip(struct irq_data *d, struct seq_file *p)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct sx150x_pinctrl *pctl = gpiochip_get_data(gc);
 
-       seq_printf(p, pctl->client->name);
+       seq_puts(p, pctl->client->name);
 }
 
 static const struct irq_chip sx150x_irq_chip = {

diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5a403915fed2c61efb2750a167bc441e2c7e402f..8742b440339eb1eeaf1098298c45a9a2aee6ed90 100644 (file)
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -2290,7 +2290,7 @@ static void rzg2l_gpio_irq_print_chip(struct irq_data *data, struct seq_file *p)
 {
        struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
 
-       seq_printf(p, dev_name(gc->parent));
+       seq_puts(p, dev_name(gc->parent));
 }
 
 static int rzg2l_gpio_irq_set_wake(struct irq_data *data, unsigned int on)