]> www.infradead.org Git - users/hch/misc.git/commitdiff
smccc: kvm_guest: Align with DISCOVER_IMPL_CPUS ABI
authorOliver Upton <oliver.upton@linux.dev>
Thu, 27 Mar 2025 16:36:15 +0000 (09:36 -0700)
committerOliver Upton <oliver.upton@linux.dev>
Tue, 1 Apr 2025 16:38:43 +0000 (09:38 -0700)
The ABI of the hypercall requires that R2 and R3 are 0. Explicitly pass
0 for these parameters.

Cc: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Fixes: 86edf6bdcf05 ("smccc/kvm_guest: Enable errata based on implementation CPUs")
Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Link: https://lore.kernel.org/r/20250327163613.2516073-1-oliver.upton@linux.dev
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
drivers/firmware/smccc/kvm_guest.c

index 5767aed25cdc055a328f096d4773b672d64b4628..ac2d3cf8a776a9d414774b3dfffd00a79439b4da 100644 (file)
@@ -95,7 +95,7 @@ void  __init kvm_arm_target_impl_cpu_init(void)
 
        for (i = 0; i < max_cpus; i++) {
                arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_DISCOVER_IMPL_CPUS_FUNC_ID,
-                                    i, &res);
+                                    i, 0, 0, &res);
                if (res.a0 != SMCCC_RET_SUCCESS) {
                        pr_warn("Discovering target implementation CPUs failed\n");
                        goto mem_free;