]> www.infradead.org Git - users/hch/misc.git/commitdiff
vfio/pds: replace bitmap_free with vfree
authorZilin Guan <zilin@seu.edu.cn>
Sat, 13 Sep 2025 15:31:54 +0000 (15:31 +0000)
committerAlex Williamson <alex.williamson@redhat.com>
Fri, 19 Sep 2025 20:48:58 +0000 (14:48 -0600)
host_seq_bmp is allocated with vzalloc but is currently freed with
bitmap_free, which uses kfree internally. This mismach prevents the
resource from being released properly and may result in memory leaks
or other issues.

Fix this by freeing host_seq_bmp with vfree to match the vzalloc
allocation.

Fixes: f232836a9152 ("vfio/pds: Add support for dirty page tracking")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Link: https://lore.kernel.org/r/20250913153154.1028835-1-zilin@seu.edu.cn
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/pds/dirty.c

index c51f5e4c3dd6d2faaff65c2d902077b4f6c3dc56..481992142f79016106964e4e6dccd995a84b56e7 100644 (file)
@@ -82,7 +82,7 @@ static int pds_vfio_dirty_alloc_bitmaps(struct pds_vfio_region *region,
 
        host_ack_bmp = vzalloc(bytes);
        if (!host_ack_bmp) {
-               bitmap_free(host_seq_bmp);
+               vfree(host_seq_bmp);
                return -ENOMEM;
        }