]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
tests/functional/qemu_test/decorators: Fix bad check for imports
authorThomas Huth <thuth@redhat.com>
Wed, 22 Jan 2025 13:43:13 +0000 (14:43 +0100)
committerThomas Huth <thuth@redhat.com>
Thu, 30 Jan 2025 09:30:36 +0000 (10:30 +0100)
skipIfMissingImports should use importlib.import_module() for checking
whether a module with the name stored in the "impname" variable is
available or not, otherwise the code tries to import a module with
the name "impname" instead.
(This bug hasn't been noticed before since there is another issue
with this decorator that will be fixed by the next patch)

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250122134315.1448794-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/functional/qemu_test/decorators.py

index df088bc0903be4adc2ecad930e4607f9bd4c278e..08f58f6b404f0298a892d048bd9d363809c7a63f 100644 (file)
@@ -2,6 +2,7 @@
 #
 # Decorators useful in functional tests
 
+import importlib
 import os
 import platform
 from unittest import skipUnless
@@ -97,7 +98,7 @@ def skipIfMissingImports(*args):
     def has_imports(importlist):
         for impname in importlist:
             try:
-                import impname
+                importlib.import_module(impname)
             except ImportError:
                 return False
         return True