]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: hns3: fix missing features due to dev->features configuration too early
authorHao Lan <lanhao@huawei.com>
Mon, 6 Jan 2025 14:36:37 +0000 (22:36 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Jan 2025 18:33:14 +0000 (10:33 -0800)
Currently, the netdev->features is configured in hns3_nic_set_features.
As a result, __netdev_update_features considers that there is no feature
difference, and the procedures of the real features are missing.

Fixes: 2a7556bb2b73 ("net: hns3: implement ndo_features_check ops for hns3 driver")
Signed-off-by: Hao Lan <lanhao@huawei.com>
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250106143642.539698-3-shaojijie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 43377a7b242645b67c2557cea100078d1e59a57a..a7e3b22f641c855186722d745cd28eaef02b4a08 100644 (file)
@@ -2452,7 +2452,6 @@ static int hns3_nic_set_features(struct net_device *netdev,
                        return ret;
        }
 
-       netdev->features = features;
        return 0;
 }