]> www.infradead.org Git - mtd-utils.git/commitdiff
libmtd_legacy: don't open device in R/W
authorBrian Norris <computersforpeace@gmail.com>
Wed, 8 Feb 2012 21:26:21 +0000 (13:26 -0800)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Wed, 29 Feb 2012 07:19:17 +0000 (09:19 +0200)
On legacy kernels with ROM devices, we can get mtdinfo errors like:

libmtd: error!: cannot open "/dev/mtd4"
        error 13 (Permission denied)
mtdinfo: error!: libmtd failed get MTD device 4 information
         error 13 (Permission denied)

We don't need O_RDRW access for informational ioctls(), so make this
O_RDONLY.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
lib/libmtd_legacy.c

index d3f16727aae38210e0f685e7d1504a289a769811..1ae99464505b76502794e7cb988e17ffdac49df1 100644 (file)
@@ -262,7 +262,7 @@ int legacy_get_dev_info(const char *node, struct mtd_dev_info *mtd)
 
        mtd->mtd_num = mtd->minor / 2;
 
-       fd = open(node, O_RDWR);
+       fd = open(node, O_RDONLY);
        if (fd == -1)
                return sys_errmsg("cannot open \"%s\"", node);