]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
drm/msm/dpu: Add a null ptr check for dpu_encoder_needs_modeset
authorChenyuan Yang <chenyuan0y@gmail.com>
Tue, 22 Jul 2025 21:17:40 +0000 (16:17 -0500)
committerRob Clark <robin.clark@oss.qualcomm.com>
Mon, 25 Aug 2025 21:00:27 +0000 (14:00 -0700)
The drm_atomic_get_new_connector_state() can return NULL if the
connector is not part of the atomic state. Add a check to prevent
a NULL pointer dereference.

This follows the same pattern used in dpu_encoder_update_topology()
within the same file, which checks for NULL before using conn_state.

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Fixes: 1ce69c265a53 ("drm/msm/dpu: move resource allocation to CRTC")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/665188/
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

index 05e5f3463e30c9a6bd5b740580720ae2bf6b3246..258edaa18fc02f837122c84842b59f2cee68d66e 100644 (file)
@@ -730,6 +730,8 @@ bool dpu_encoder_needs_modeset(struct drm_encoder *drm_enc, struct drm_atomic_st
                return false;
 
        conn_state = drm_atomic_get_new_connector_state(state, connector);
+       if (!conn_state)
+               return false;
 
        /**
         * These checks are duplicated from dpu_encoder_update_topology() since