rxgen: The abort table comparator needs to handle big numbers

The abort table comparator needs to handle big numbers (larger than
0x7fffffff).  Subtracting a small number from such a big number and then
casting to a signed int results in a negative number, which bsearch()
interprets as indicating that the bigger number is smaller than the smaller
number.

Signed-off-by: David Howells <dhowells@redhat.com>

diff --git a/py_rxgen.c b/py_rxgen.c
index 6a261d290f39ba325c398ee7fadf2af93365f916..6c90004c2072e75529a626705cb8913906ea0cc9 100644 (file)
--- a/py_rxgen.c
+++ b/py_rxgen.c
@@ -1037,8 +1037,15 @@ error:
 static int py_rxgen_received_abort_cmp(const void *key, const void *_entry)
 {
        const struct kafs_abort_list *entry = _entry;
+       int ret;
 
-       return (uint32_t)(unsigned long)key - entry->id;
+       if ((uint32_t)(unsigned long)key > entry->id)
+               ret = 1;
+       else if ((uint32_t)(unsigned long)key < entry->id)
+               ret = -1;
+       else
+               ret = 0;
+       return ret;
 }
 
 /*