]> www.infradead.org Git - linux.git/commitdiff
driver core: make driver_[create|remove]_file take a const *
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Jul 2024 08:15:45 +0000 (10:15 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jul 2024 07:36:02 +0000 (09:36 +0200)
The functions driver_create_file() and driver_remove_file() do not
modify the struct device_driver structure directly, so they are safe to
be marked as a constant pointer type.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/2024070844-volley-hatchling-c812@gregkh
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/driver.c
include/linux/device/driver.h

index 85b4c00df078ab29d8ee60e9f00d110757d78991..3eeafdb79d0e217d39a8acbe37c3ddfd61a20109 100644 (file)
@@ -173,7 +173,7 @@ EXPORT_SYMBOL_GPL(driver_find_device);
  * @drv: driver.
  * @attr: driver attribute descriptor.
  */
-int driver_create_file(struct device_driver *drv,
+int driver_create_file(const struct device_driver *drv,
                       const struct driver_attribute *attr)
 {
        int error;
@@ -191,7 +191,7 @@ EXPORT_SYMBOL_GPL(driver_create_file);
  * @drv: driver.
  * @attr: driver attribute descriptor.
  */
-void driver_remove_file(struct device_driver *drv,
+void driver_remove_file(const struct device_driver *drv,
                        const struct driver_attribute *attr)
 {
        if (drv)
index 7738f458995fba858e0e3ead9e5d12ceed35730d..dceb36f1c42cf3e59c207b3db9a8fba2b3d7b99f 100644 (file)
@@ -146,9 +146,9 @@ struct driver_attribute {
 #define DRIVER_ATTR_WO(_name) \
        struct driver_attribute driver_attr_##_name = __ATTR_WO(_name)
 
-int __must_check driver_create_file(struct device_driver *driver,
+int __must_check driver_create_file(const struct device_driver *driver,
                                    const struct driver_attribute *attr);
-void driver_remove_file(struct device_driver *driver,
+void driver_remove_file(const struct device_driver *driver,
                        const struct driver_attribute *attr);
 
 int driver_set_override(struct device *dev, const char **override,